Propose a 2025H2 goal for comprehensive niche checks #333
+105
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c3t3a
force-pushed
the
niche-check-h2-goal
branch
2 times, most recently
from
cd2512b to
7504415
Compare
1c3t3a
force-pushed
the
niche-check-h2-goal
branch
from
7504415 to
dd1dcbe
Compare
RalfJung
reviewed
Jul 16, 2025
|
|
||
| ### The status quo | ||
|
|
||
| While [Miri](google.com/search?q=miri+rust&oq=miri+rust&gs_lcrp=EgZjaHJvbWUqDQgAEAAYkQIYgAQYigUyDQgAEAAYkQIYgAQYigUyCAgBEAAYFhgeMggIAhCAMQABgWGB4yBggEEEUYPDIGCAUQRRg8MgYIBhBFGDwyBggHEEUYQNIBCDI1MzJqMGo3qAIAsAIA&sourceid=chrome&ie=UTF-8) |
There was a problem hiding this comment.
Why does this not just link to the Miri repo...?
| we e.g. inject the check for every use of an invalid enum, we already observe UB, | ||
| and the compiler may insert a `trunc` of the discriminant value when trying to | ||
| get the value. The UB may already have happened. Similar, any check for an | ||
| argument marked `nonnull` will be optimized out by the compiler. |
There was a problem hiding this comment.
I don't understand this paragraph...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up goal to the previous one that I did in H1. It's continuing the work by making the checks more efficient (broader coverage) and cover all niches.
cc @saethlin, @RalfJung who helped me with the previous goal
Rendered