Skip to content

Fix min_ident_chars: ignore on trait impl. #15275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

t-webber
Copy link

@t-webber t-webber commented Jul 14, 2025

fixes #13396

changelog: [min_ident_chars]: ignore lint when implementing a trait, to respect [renamed_function_params]

@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 14, 2025
Copy link

Lintcheck changes for baded8c

Lint Added Removed Changed
clippy::min_ident_chars 0 2453 39

This comment will be updated if you push new changes

@t-webber t-webber changed the title Min idents char Fix min_ident_chars: ignore on trait impl. Jul 14, 2025
@samueltardieu
Copy link
Contributor

For a local trait, it should warn about the short parameter name in the trait method definition. I don't see a test for this, and I suspect it won't warn. To suppress warnings about trait implementations, we should ensure it warns at the trait definition so that users are warned at least once about the usage of short identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

min_ident_chars triggers on implementation block for foreign traits
4 participants