Fix if_then_some_else_none FP when require type coercion
#15267
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Lintcheck changes for b6c0d63
This comment will be updated if you push new changes |
rustbot
removed
the
S-waiting-on-review
blyxyas
added
the
S-waiting-on-author
blyxyas
reviewed
Jul 13, 2025
| @@ -79,6 +80,7 @@ impl<'tcx> LateLintPass<'tcx> for IfThenSomeElseNone { | |||
| && !expr.span.in_external_macro(cx.sess().source_map()) | |||
| && self.msrv.meets(cx, msrvs::BOOL_THEN) | |||
| && !contains_return(then_block.stmts) | |||
| && !expr_requires_coercion(cx, then_expr) | |||
There was a problem hiding this comment.
In this case, what do you think about, instead of completely discarding the block if it requires type coercion, we check if we're in a trait item function (we cannot change the signatures of those functions) and if we're in just a normal function, we emit a non-MachineApplicable suggestion with a note about the user will have to modify the return type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15257
changelog: [
if_then_some_else_none] fix FP when require type coercion