Skip to content

fix suggestion causes error of needless_for_each #15262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix suggestion causes error of needless_for_each #15262

wants to merge 1 commit into from
+47 −8

Conversation

relaxcn
Copy link
Contributor

@relaxcn relaxcn commented Jul 12, 2025 •
edited by rustbot
Loading

Fixes: #15256

changelog: fix suggestion causes error of [needless_for_each] when the body.value comes from macro expansion.

@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 12, 2025
Jarcho
Jarcho requested changes Jul 14, 2025
View reviewed changes
clippy_lints/src/needless_for_each.rs
@@ -101,18 +101,23 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessForEach {

let body_param_sugg = snippet_with_applicability(cx, body.params[0].pat.span, "..", &mut applicability);
let for_each_rev_sugg = snippet_with_applicability(cx, for_each_recv.span, "..", &mut applicability);
let body_value_sugg = snippet_with_applicability(cx, body.value.span, "..", &mut applicability);
let body_value_sugg =
snippet_with_applicability(cx, get_user_code_span(body.value.span), "..", &mut applicability);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just use snippet_with_context.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

needless-for-each expands macros in suggestion
3 participants
@relaxcn @rustbot @Jarcho