disallowed_methods: handle full paths as replacement for method call #15242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can't do the "correct" thing, and check if the method is defined, because `FnCtxt::lookup_method` isn't accessible in Clippy. To work around this problem, we convert method calls to FQP syntax if the user specifies a full path as a replacement. If they specify only a name, then we only replace the name. Since clippy.toml resolves paths from the top level of the crate, this is basically guaranteed to produce a correct result, if we ignore method call adjustments like autoderef.
rustbot
added
the
S-waiting-on-review
ada4a
reviewed
Jul 11, 2025
Co-authored-by: Ada Alakbarova <58857108+ada4a@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can't do the "correct" thing, and check if the method is defined, because
FnCtxt::lookup_methodisn't accessible in Clippy.To work around this problem, we convert method calls to FQP syntax if the user specifies a full path as a replacement. If they specify only a name, then we only replace the name. Since clippy.toml resolves paths from the top level of the crate, this is basically guaranteed to produce a correct result, if we ignore method call adjustments like autoderef.
changelog: [
disallowed_methods]: correctly handle methods called by FQPFixes #15067