Hide the sidebar when collapsed to prevent browser search to find text from it #2725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
search-collapsed
branch
4 times, most recently
from
44dfae5 to
9c1d6db
Compare
|
Thanks to the GUI tests, I uncovered the case where the window size is too small and therefore the sidebar should not be displayed by default. =D |
|
Anyway, it's ready for review. |
|
Thank you very much! This seems to introduce a few regressions:
Would you be able to look into those issues? |
|
On safari, sadly no. But on firefox, definitely. :) |
GuillaumeGomez
force-pushed
the
search-collapsed
branch
from
9c1d6db to
f4eacc3
Compare
|
Fixed. I also extended the GUI test to ensure it doesn't happen again. |
When showing the sidebar, Safari was causing the sidebar to snap into place without animating. This is apparently some well-known issue where it doesn't like adding new elements (or changing display) and toggling an animated transition in the same event loop.
|
Thanks, I think I have fixed the issue that was happening on Safari. |
GuillaumeGomez
commented
Jul 7, 2025
| // Workaround for Safari skipping the animation when changing | ||
| // `display` and a transform in the same event loop. This forces a | ||
| // reflow after updating the display. | ||
| sidebar.offsetHeight; |
There was a problem hiding this comment.
I'm very confused about this fix considering it does nothing. Dark magic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2721.
For the GUI test, I need to add a new command to ensure the text is not searchable when collapsed. I opened an issue for that in browser-ui-test: GuillaumeGomez/browser-UI-test#659.