-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add absolute links support #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
bbc4758
82a6ba2
30b2ca3
ec2c304
7c42e4a
fe21b13
ef33e4b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -582,6 +582,8 @@ pub struct HtmlConfig { | |
pub input_404: Option<String>, | ||
/// Absolute url to site, used to emit correct paths for the 404 page, which might be accessed in a deeply nested directory | ||
pub site_url: Option<String>, | ||
/// Prepend the `site_url` in links with absolute path. | ||
pub use_site_url_as_root: bool, | ||
Comment on lines
+585
to
+586
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm, so technically adding this is a breaking change since |
||
/// The DNS subdomain or apex domain at which your book will be hosted. This | ||
/// string will be written to a file named CNAME in the root of your site, | ||
/// as required by GitHub Pages (see [*Managing a custom domain for your | ||
|
@@ -632,6 +634,7 @@ impl Default for HtmlConfig { | |
edit_url_template: None, | ||
input_404: None, | ||
site_url: None, | ||
use_site_url_as_root: false, | ||
cname: None, | ||
live_reload_endpoint: None, | ||
redirect: HashMap::new(), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add this to the TOML summary up above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, done,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a user, I would wonder "what links are those"? It could be