Read symbolic value at symbolic address #152
Open
+82
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WB operations. Update test data to include symbolic index value handling in storeBytes. Adjust formatting for clarity.
…ing a boolean wrapper for symbolic writes. This update includes detailed explanations of termination control, reordering for optimization, and write consolidation strategies. Adjusted comments for clarity and improved documentation.
Stevengre
force-pushed
the
jh/sym-read-mem
branch
from
20bd897 to
8c9abdd
Compare
tothtamas28
reviewed
Jul 9, 2025
Comment on lines
+33
to
+34
| rule pickFront(PICK, #WB(_, _, _, _, B:SparseBytes)) => pickFront(PICK, B) | ||
| // omit this condition to make it easy to simplify: requires 0 =/=Int I |
There was a problem hiding this comment.
This would require PICK <=Int I or NUM ==Int 0 I think.
Comment on lines
+38
to
+39
| rule dropFront(DROP, #WB(FLAG, I, V, NUM, B:SparseBytes)) => #WB(FLAG, I -Int DROP, V, NUM, dropFront(DROP, B)) | ||
| [simplification(45)] |
There was a problem hiding this comment.
Consider DROP > I. In that case, WriteBytes(I -Int DROP, ...) is .SparseBytes.
| [simplification(45)] | ||
|
|
||
|
|
||
| syntax SparseBytes ::= SparseBytes ">>SparseBytes" Int [function, total] |
There was a problem hiding this comment.
Please document the intended semantics of this symbol.
|
|
||
| syntax SparseBytes ::= SparseBytes ">>SparseBytes" Int [function, total] | ||
| // It's not correct, but just make this function total | ||
| rule B >>SparseBytes _ => B [concrete] |
There was a problem hiding this comment.
This looks dangerous, Why is this rule necessary?
| rule B >>SparseBytes _ => B [concrete] | ||
| rule #WB(FLAG, I, V, NUM, B:SparseBytes) >>SparseBytes SHIFT => #WB(FLAG, I, (V &Int (2 ^Int (NUM *Int 8)) -Int 1) >>Int (SHIFT *Int 8), NUM, B >>SparseBytes SHIFT) | ||
| requires SHIFT >=Int 0 [simplification(45), preserves-definedness] | ||
| rule B:SparseBytes >>SparseBytes _ => B [simplification] |
There was a problem hiding this comment.
This also looks unsound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.