Fix onBlock not being called during a block
#121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmariuzzo
reviewed
Nov 28, 2022
| @@ -102,7 +102,7 @@ class NewWindow extends React.PureComponent { | |||
|
|
|||
| // Open a new window. | |||
| this.window = window.open(url, name, toWindowFeatures(features)) | |||
| this.container = this.window.document.createElement('div') | |||
| this.container = this.window?.document.createElement('div') | |||
rmariuzzo
reviewed
Nov 28, 2022
| @@ -143,6 +143,8 @@ class NewWindow extends React.PureComponent { | |||
|
|
|||
| // Release anything bound to this component before the new window unload. | |||
| this.window.addEventListener('beforeunload', () => this.release()) | |||
|
|
|||
| this.setState({ mounted: true }) | |||
There was a problem hiding this comment.
Need to check why is this needed.
rmariuzzo
changed the title
onBlock not being called during a block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firefox,
i noticed the script would crash if the
this.windowis null on linereact-new-window/src/NewWindow.js
Line 102 in d9dbb75
and
this.setState({ mounted: true })is set regardless.This pr fixes this issue which allows onBlock to be called.