Skip to content

Fix inside comment printing for empty dict #7654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 16, 2025
Merged

Fix inside comment printing for empty dict #7654

merged 5 commits into from
Jul 16, 2025
+16 −3

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented Jul 16, 2025

Fix #7652

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 16, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7654

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7654

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7654

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7654

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7654

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7654

commit: 9880aed

cknitt
cknitt approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🎉

@cknitt cknitt merged commit 0ae9d12 into rescript-lang:master Jul 16, 2025
27 checks passed
@shulhi shulhi deleted the fix/dict-comment branch July 17, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting empty dictionary deletes any comments and inserts invalid trailing comma
2 participants
@shulhi @cknitt