Rust implementation of "rescript format"

[cknitt]

Do not forward the rescript format command to the legacy JS cli anymore, instead implement the functionality natively in Rust.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7603

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7603

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7603

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7603

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7603

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7603

commit: 8f2970b

[nojaf]

rewatch format --help

thread 'main' panicked at /Users/nojaf/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.31/src/builder/debug_asserts.rs:570:9:
Positional argument `[FOLDER]` *must* have `required(true)` or `last(true)` set because a prior positional argument (`[FILES]...`) has `num_args(1..)`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

There is something weird in the setup here, the help crashes.
Might be related to the files: Vec<string>, but I'm not sure.

[nojaf]

This worked well with --all in my monorepo setup! Great job!

One small thing to follow up on is that rescript format --check without any input doesn’t provide any output. Perhaps we should log a message indicating that no input was found. I encountered this issue when I forgot to include the --all argument, which was a bit confusing at first.

[zth]

Note for the future - we could add an option to also format docstrings, using the new tools format command.

[cknitt]

@nojaf Thanks a lot for testing! Could you retry? I now specified that either --all, --stdin, or files must be present.

[nojaf]

Thanks! That worked for me: