Optional Enumerables do not create empty instances when omitted #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #15. If an
Enumerable
attribute (map or list-of-maps) is flagged as optional, and that attribute is not in the input, I'd expect the output fromSpeck.validate/2
to be as minimal as possible. For a top-level attribute, that means anil
value. For anything below the top level, that would mean being entirely omitted from the output. To make this happen, I've made the handling of optional values a higher priority inapply_filters
.One behavioural change not directly related to the above is that a non-optional
Enumerable
that is omitted will not recursively report:not_found
errors. Instead, the map/list-of-maps will itself be marked as:not_found
, and the interior elements skipped entirely. The old behaviour is easy enough to re-implement by moving a condition inapply_filters
.