Skip to content

Remove deprecated dnsResolver option (#3328) #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

The-East-Wind
Copy link

@The-East-Wind The-East-Wind commented Jun 24, 2025

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Resolves parts of #3328

Changes

  1. Removed usages of ClientResources#dnsResolver
  2. Removed ClientResources#dnsResolver and all of it's implementations in DefaultClientResources
  3. Removed redundant classes which are no longer relevant
  4. Removed deprecated JVM_DEFAULT DnsResolver
  5. Fixed failing tests

Followup questions for maintainers

  1. Should DnsResolver and it's implementations be removed or should they continue to exist
  2. If DnsResolver is to be removed should SockerAddressResolver make direct use of netty's AddressResolverGroup

…p instantiation

Signed-off-by: The-East-Wind <hariatul1998@gmail.com>
Signed-off-by: The-East-Wind <hariatul1998@gmail.com>
Signed-off-by: The-East-Wind <hariatul1998@gmail.com>
…olver is a required dependency

Signed-off-by: The-East-Wind <hariatul1998@gmail.com>
Signed-off-by: The-East-Wind <hariatul1998@gmail.com>
Signed-off-by: The-East-Wind <hariatul1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant