Skip to content

Add GitHub App integration type #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2025
Merged

Add GitHub App integration type #12273

merged 6 commits into from
Jul 2, 2025

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Jun 26, 2025

I'm treating the GHA integration as a remote integration, with just
enough configuration to display something in the UI.

I just stubbed in the handling of data from the GHA for now.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We need to work on the small TODOs pending.

I'm treating the GHA integration as a remote integration, with just
enough configuration to display something in the UI.
@agjohnson agjohnson force-pushed the agj/githubapp-integration branch from 8fce4c3 to ff7ecc9 Compare June 30, 2025 22:59
@agjohnson
Copy link
Contributor Author

Had to rebase to push my commit up to this branch. I don't really know what GitHub is doing, I shouldn't have had to rebase at all -- commits looked the same locally and on this PR 😕

@agjohnson agjohnson marked this pull request as ready for review July 1, 2025 00:40
@agjohnson agjohnson requested a review from a team as a code owner July 1, 2025 00:40
@agjohnson agjohnson requested a review from humitos July 1, 2025 00:40
@agjohnson agjohnson requested a review from stsewd July 1, 2025 00:40
@agjohnson
Copy link
Contributor Author

Added test and migration, this doesn't yet try to add the integration for new or existing projects though. That we can do next, though this is still manually usable in it's current form.

@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Jul 1, 2025
@agjohnson agjohnson moved this from Planned to Needs review in 📍Roadmap Jul 1, 2025
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some small changes.

@agjohnson agjohnson merged commit 5e04368 into main Jul 2, 2025
7 checks passed
@agjohnson agjohnson deleted the agj/githubapp-integration branch July 2, 2025 18:33
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants