-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add GitHub App integration type #12273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We need to work on the small TODOs pending.
I'm treating the GHA integration as a remote integration, with just enough configuration to display something in the UI.
8fce4c3
to
ff7ecc9
Compare
Had to rebase to push my commit up to this branch. I don't really know what GitHub is doing, I shouldn't have had to rebase at all -- commits looked the same locally and on this PR 😕 |
Added test and migration, this doesn't yet try to add the integration for new or existing projects though. That we can do next, though this is still manually usable in it's current form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with some small changes.
I'm treating the GHA integration as a remote integration, with just
enough configuration to display something in the UI.
I just stubbed in the handling of data from the GHA for now.