fix(actions): migrate deploy docs step to use external action #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an external action here saves us from setting this up manually. also removes an uneeded dev dependency, as we aren't deploying the docs locally anymore.
bpas247
commented
Sep 2, 2019
.github/workflows/deploy-docs.yml
Outdated
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: yarn deploy-docs | ||
| ACCESS_TOKEN: ${{ secrets.ACCESS_TOKEN }} |
There was a problem hiding this comment.
So this is unfortunate, but until server-to-server requests kick off page builds, there isn't a good workaround for this.
We have a couple options here:
- Wait until this issue is resolved and the subsequent PR is merged.
- Create a machine user and create a new secret out of that.
IMO the former seems like the less painful route to go.
|
Wait, if JamesIves/github-pages-deploy-action#13 was merged, do we still need that token? |
also updates the configuration to account for breaking changes.
taion
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an external action here saves us from setting this up
manually.
also removes an uneeded dev dependency, as we aren't deploying
the docs locally anymore.