Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Added support for synchronous writes #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

burtbeckwith
Copy link
Collaborator

I'm working with Luis Arias to make this available for the Grails plugin

Burt Beckwith added 2 commits February 29, 2012 15:35
@raykrueger
Copy link
Owner

Sorry for the delay. I really don't want to pull in the massive cleanup commit (87d323c). It's a bit heavy handed, if there are specific things that should be fixed call those out.

Commit cd7ab28 is simple enough but it breaks the build. Please run "mvn test" and ensure all tests pass.

@burtbeckwith
Copy link
Collaborator Author

I don't use Maven, but I ran all the tests except the Hibernate ones and everything worked. Is there a compile problem, or did particular tests fail? Could you email me the build output?

@burtbeckwith
Copy link
Collaborator Author

There's a change in the cleanup commit that might be the culprit - in AbstractKeyStrategyTestCase I had to change shouldFailWithCause to shouldFail. I wasn't sure how the tests could have been passing before, but I didn't run them until after my changes. But I can't see how what I did could have affected that.

@kaaloo
Copy link

kaaloo commented Mar 5, 2012

I just ran mvn test after cherrypicking Commit cd87ab28 w/o any issues. My fork is up to date.

@kaaloo
Copy link

kaaloo commented Mar 5, 2012

You might want to get commit af12ed9 too since there was an issue with logging in the update.

@raykrueger
Copy link
Owner

I found the problem with the tests failing on my side. If you run them with mvn test the mock log appender was left set as the only appender. That was then failing it's assertion during other tests.

I've merged cd7ab28 and fixed the Logger test and pushed to burtbeckwith-contrib. I'll wait for verification of the NullPointerException before proceeding.

@raykrueger
Copy link
Owner

Thanks, I just pushed to that logger fix to burtbeckwith-contrib as well.
https://github.com/raykrueger/hibernate-memcached/tree/burtbeckwith-contrib

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants