Skip to content

Fix dtype selective build check in elementwise_util #12183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jul 2, 2025

I think I got this wrong in #11975 -- the compute_dtype is the one type that is NOT related to selective build.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jul 2, 2025

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from manuelcandales as a code owner July 2, 2025 23:36
Copy link

pytorch-bot bot commented Jul 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12183

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit 71d32cc with merge base 02454eb (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 2, 2025
I think I got this wrong in #11975 -- the compute_dtype is the one type that is NOT related to selective build.


ghstack-source-id: db55c4a
ghstack-comment-id: 3029669540
Pull-Request-resolved: #12183
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2025
@swolchok swolchok requested review from kimishpatel and lucylq July 2, 2025 23:42
@swolchok
Copy link
Contributor Author

swolchok commented Jul 2, 2025

  • Kimish and Lucy because we just discussed this in person

@swolchok swolchok added the release notes: none Do not include this in the release notes label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants