Skip to content

refactor XNNPACK's ukernel config srcs #12152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Jul 1, 2025

little refactoring for getting ukernel_config_srcs from xnnpack's build system

Copy link

pytorch-bot bot commented Jul 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12152

Note: Links to docs will display an error until the docs builds have been completed.

❌ 84 New Failures

As of commit 17ee2f3 with merge base 7e28a04 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2025
@mcr229 mcr229 marked this pull request as ready for review July 1, 2025 23:42
@mcr229 mcr229 requested a review from digantdesai as a code owner July 1, 2025 23:42
@mcr229 mcr229 requested a review from GregoryComer July 1, 2025 23:42
Copy link

github-actions bot commented Jul 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

ghstack-source-id: 3b4b7d1
ghstack-comment-id: 3025865163
Pull Request resolved: pytorch#12153
@@ -56,8 +30,12 @@ def get_xnnpack_headers():
])
return src_headers | include_headers | ukernel_headers

def get_ukernel_config_srcs():
return subdir_glob([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should do this more instead of lists.

ghstack-source-id: 3c7df13
ghstack-comment-id: 3025865277
Pull Request resolved: pytorch#12154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants