Skip to content

[not for merge] Add armv8 support in buck shim #12146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[not for merge] Add armv8 support in buck shim #12146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions shim_et/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@ system_python_bootstrap_toolchain(
visibility = ["PUBLIC"],
)

execution_platform(
name = "android-arm32",
cpu_configuration = "prelude//cpu:arm32",
os_configuration = "prelude//os:android",
# REVIEW: not sure if this is correct
use_windows_path_separators = host_info().os.is_windows,
visibility = ["PUBLIC"],
)

execution_platform(
name = "android-arm64",
cpu_configuration = "prelude//cpu:arm64",
Expand Down
2 changes: 2 additions & 0 deletions tools/cmake/Utils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ function(extract_sources sources_file)
set(target_platforms_arg "--target-platforms=shim_et//:android-arm64")
elseif("${ANDROID_ABI}" STREQUAL "x86_64")
set(target_platforms_arg "--target-platforms=shim_et//:android-x86_64")
elseif("${ANDROID_ABI}" STREQUAL "armeabi-v7a")
set(target_platforms_arg "--target-platforms=shim_et//:android-arm32")
else()
message(
FATAL_ERROR
Expand Down
Loading