gh-135075: Make PyObject_SetAttr() fail with NULL value and exception #136180
Conversation
…eption Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.
| @@ -197,6 +197,10 @@ Object Protocol | |||
| in favour of using :c:func:`PyObject_DelAttr`, but there are currently no | |||
| plans to remove it. | |||
| The function must not be called with ``NULL`` *v* and an an exception set. | |||
There was a problem hiding this comment.
This paragraph and the previous one are about the same case -- when v is NULL. You can pass NULL, but this is soft-deprecated, and no error should be set. Why not merge them?
And maybe add versionchanged?
| obj.attr = 123 | ||
| with self.assertRaises(SystemError): | ||
| _testcapi.object_setattr_null_exc(obj, 'attr') | ||
| self.assertTrue(hasattr(obj, 'attr')) |
There was a problem hiding this comment.
assertHasAttr
Also check __context__ or __cause__ of the exception.
| return NULL; | ||
| } | ||
|
|
||
| PyErr_SetString(PyExc_ValueError, "error"); |
There was a problem hiding this comment.
You can pass an exception as argument. Then you can check __context__ or __cause__ of SystemError by identity.
| { | ||
| PyObject *obj; | ||
| const char *name; | ||
| if (!PyArg_ParseTuple(args, "Os", &obj, &name)) { |
There was a problem hiding this comment.
Use z#. So you can test with undecodable name -- this will allow to test that the value is tested for NULL in PyObject_SetAttrString, not only in PyObject_SetAttr, and that it is tested before attempting to decode the name.
Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.
📚 Documentation preview 📚: https://cpython-previews--136180.org.readthedocs.build/