fix bounce msg processing issue #2833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: master_jedy <yura.zarudny@gmail.com>
|
@masterjedy is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the bounced message processing issue.
Rationale
Checking bounce flag and ignoring bounced message occurs after trying to load reference in the tx body, but bounced messages don't have references, so it causes a crash.
The check for empty slice at the botton of the recv() function doesn't help, because bounced messages have a body starting with 0xFFFF.... It only allows to keep received TONs.
How has this been tested?
The change is tested in other project, and I ran this project's tests - they pass.