fix: support only one output wheel from repair #2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
mayeut
approved these changes
Jun 27, 2025
joerick
approved these changes
Jun 29, 2025
|
Should we consider this fine for a patch release, or should we hold it for a minor release? |
|
Hmm... maybe should wait for a minor. It might break somebody somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the ability to pick up multiple output wheels from the linux repair step, brining it into line with the other operating systems. Auditwheel has, as far as I can tell, switched some time ago to just using multiple tags, not outputting multiple wheels. This will simplify #2469. If it's not true, then I can add multiple wheel outputs to that PR instead, but I think this is the cleaner solution.