fix: docs examples python version in tests #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing test on docs example use the version of Python that is specified by the test block to set the target version of Python. This fixes failures with later ruff versions which validate the syntax according to the target Python version more strictly, which was resulting in a failure then except* was used in the example code against Python 3.9.
stevenh
force-pushed
the
fix/examples-python-version
branch
from
00c9324 to
6c5a6e7
Compare
|
I think this was on purpose, tho. Wasn't it @samuelcolvin ? |
|
I had updated dependencies at the time, so I suspect that if you bump the version of ruff, you'll start seeing test failures when the examples are run with ruff target_version=py39 and using features like except* which aren't in python 3.9, even though the example block explicitly requests a higher version. Hope that helps clarify what triggered it for me. |
|
There's also a related PR to pytest-examples here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing test on docs example use the version of Python that is specified by the test block to set the target version of Python.
This fixes failures with later ruff versions which validate the syntax according to the target Python version more strictly, which was resulting in a failure when
except*was used in the example code against Python 3.9.