-
-
Notifications
You must be signed in to change notification settings - Fork 892
Add issue.remove_field_value() #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickbroon
wants to merge
2
commits into
pycontribs:main
Choose a base branch
from
nickbroon:nickbroon-remove_field_value
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nickbroon thanks for this! Do you think we can add a test (to: tests\resources\test_issue.py) where perhaps we
|
550daa1
to
3046ac5
Compare
adehad, I pushed a update to the Pull Request that adds a test that exercises both |
7669ec4
to
b57c08d
Compare
The UT failures look unrelated to the changes in the PR. |
87694e9
to
221a0a9
Compare
Complements the existing add_field_value()
for example to add/remove a version the name or id must be used: issue.add_field_value('fixVersions', {'name': version})` or `issue.add_field_value("fixVersions", {"id": fix_version.id})` Closes: pycontribs#1724
221a0a9
to
fdd083b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements the existing add_field_value()