Migrate site to new format #303
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmanuel1
reviewed
Jun 24, 2025
Comment on lines
+20
to
+39
| <div class="list-item__inner"> | ||
| <div class="list-item__icon"></div> | ||
| <<%=heading_lvl%> class="list-item__name"><%= options[item].title %></<%=heading_lvl%>> | ||
| <div class="list-item__summary"><%= options[item].description %></div> | ||
|
|
||
| <% if (options[item].hasOwnProperty("alerts")) { %> | ||
| <% for (const alert of options[item].alerts) { %> | ||
| <div class="list-item__alert icon-alert"> | ||
| <%=alert%> | ||
| </div> | ||
| <% } %> | ||
| <% } %> | ||
|
|
||
| <ul class="list-item__expandable hide" id="expandable-<%= item_key.concat("-",item) %>" data-status="closed"> | ||
| <%- include("download_list", { options: options[item].options, item_key: item_key.concat("-",item), heading_lvl: "h2" }) %> | ||
| </ul> | ||
| </div> | ||
| <div class="list-item__dropdown-btn"> | ||
| <button id="expandable-<%= item_key.concat("-",item) %>-btn" class="icon-chevron-down" onclick="expandOrCollapseDownloadSection('expandable-<%=item_key.concat("-",item)%>-btn')"></button> | ||
| </div> |
There was a problem hiding this comment.
Would you consider using a details element for this?
Also, the expand button doesn't have an accessible name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates our existing homepage to
11tyjust like we are doing on the documentation side and blog side.This is just about the last thing we need to do before we are ready to launch our new web presence all at once.
This PR has a few big hurdles to get over that we haven't had to touch yet elsewhere:
If you have any ideas (especially on the home page) I'm more than happy to hear them and see where we might want to go with things.
With the amount of change happening, it might be a good idea to flesh out exactly what will stay here for those slightly more unfamiliar.
Below is a layout of the web resources we currently have (that are related to this project) and where they will end up:
pulsar-edit.dev/=>pulsar-edit.dev| Homepage: Covered in this PR.pulsar-edit.dev/download.html=>pulsar-edit.dev/download/| Download Page: Covered in this PR.pulsar-edit.dev/about.html=>pulsar-edit.dev/about/| About Page: Covered in this PR.pulsar-edit.dev/community.html=>pulsar-edit.dev/community/| Community Spaces: Covered in this PR.pulsar-edit.dev/donate.html=>pulsar-edit.dev/donate/| Donate Page: Covered in this PR.pulsar-edit.dev/blog=>blog.pulsar-edit.dev| Blog: Migrated to repositorypulsar-edit/blogpulsar-edit.dev/docs=>docs.pulsar-edit.dev| Documentation: Migrated to repositorypulsar-edit/documentationSo in short, that only leaves this repository with the following resources:
With the only one of these that would see regular updates is the download page. Otherwise it's very possible these resources may be relatively static.
My biggest concern is we in the past had a contributor come along and redesign the homepage to something that while really cool, has significant performance issues on lower end PCs. Obviously it'd be best to find a new homepage design that works well everywhere, fits our current new theming, and possibly more importantly is something everyone on the team is happy with being representative of a users first experience of Pulsar.