Skip to content

Add support for Editor Coroutines #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jdnichollsc
Copy link
Member

Use EditorCoroutine option to support Editor Coroutines for a request

@jdnichollsc jdnichollsc force-pushed the feature/editor-coroutines branch from 7de038d to 55de6d4 Compare January 2, 2022 18:04
@maifeeulasad
Copy link
Collaborator

@jdnichollsc, taking a look at it.

@jdnichollsc
Copy link
Member Author

To avoid this dependency maybe we can have another branch for this feature, what do you think?

Copy link
Collaborator

@maifeeulasad maifeeulasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awesome.

Just on a side note:

  • Maybe we can add some examples, it may come in handy (I know it's more like, how to write an Editor scripts and all)

@RunoLight
Copy link

To avoid this dependency maybe we can have another branch for this feature, what do you think?

Maintaining multiple versions (with and without editor coroutines) could get quite complex. I think it's possible to support both cases using a conditional compilation flag — something like #if with a specific preprocessor define. Odin Serializer and Inspector use a similar approach with certain libraries. They then just notice about that in readme, so user will know he can use that and how to enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants