fix: overwritten envFrom #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
This PR fixes an issue I introduced in #192 which I missed as it wasn't an issue in my testing environment.
#192 gives the user the option to specify an
envFrom
field. The problem is that if the user also provides ancclGdrEnvConfigMap
value, then this results in anotherenvFrom
field being created which overwrites the first. I wasn't providingncclGdrEnvConfigMap
in the env I tested in, so I missed this fact.This PR merges any provided envFrom fields.
Verification steps
Checks
Now tested in an environment where I also specify
ncclGdrEnvConfigMap