Skip to content

fix: overwritten envFrom #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

Conversation

garrett361
Copy link
Contributor

Issue link

What changes have been made

This PR fixes an issue I introduced in #192 which I missed as it wasn't an issue in my testing environment.

#192 gives the user the option to specify an envFrom field. The problem is that if the user also provides a ncclGdrEnvConfigMap value, then this results in another envFrom field being created which overwrites the first. I wasn't providing ncclGdrEnvConfigMap in the env I tested in, so I missed this fact.

This PR merges any provided envFrom fields.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Now tested in an environment where I also specify ncclGdrEnvConfigMap

Copy link
Collaborator

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dgrove-oss dgrove-oss merged commit 3e449cd into project-codeflare:main Jul 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants