-
Notifications
You must be signed in to change notification settings - Fork 151
[4기 홍혁준] Mission 1, 3 PR 제출합니다 #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hongdosan
wants to merge
19
commits into
prgrms-be-devcourse:HyuckJuneHong
Choose a base branch
from
hongdosan:HyuckJuneHong
base: HyuckJuneHong
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a184c3a
init : Project 초기화
hongdosan c0eef79
test : 유저 회원 엔티티 생성 테스트
hongdosan 796bd16
docs : Member 명세서 작성
hongdosan 5d361c1
test : Member Repository save 테스트
hongdosan 6c92946
test : Member Email 유효성 검증 테스트
hongdosan 55b744b
test : Member Cell Phone 유효성 검증 테스트
hongdosan c2eb1c0
test : Member Address가 잘 생성되는 지 검증
hongdosan 87e7891
test : Member Service createMember Test
hongdosan b95fcb8
test : Member Controller 등록 API Test
hongdosan 629942a
refactor : Member Test DisplayName 설정
hongdosan 305bac1
test : Member Auditing CreateAt Test
hongdosan d6195b4
refactor : Member Test Method Name
hongdosan 1655256
test : email에 대한 회원을 조회하는 기능 테스트 및 구현
hongdosan 0fa4e3a
test : member 전체 조회 테스트
hongdosan d241dec
refactor : 테스트 DisplayName 변경
hongdosan c5f21c1
test : 회원 삭제 기능 테스트 및 구현
hongdosan ff17b25
test : 회원 수정 시 수정일 검증 테스트 추가
hongdosan ae1cda5
feat : 연관관계 설정
hongdosan 505dffd
fix : @Transactional 추가
hongdosan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,286 @@ | ||
# Created by https://www.toptal.com/developers/gitignore/api/intellij+all,intellij+iml,intellij,gradle,git,netbeans | ||
# Edit at https://www.toptal.com/developers/gitignore?templates=intellij+all,intellij+iml,intellij,gradle,git,netbeans | ||
|
||
### Git ### | ||
# Created by git for backups. To disable backups in Git: | ||
# $ git config --global mergetool.keepBackup false | ||
*.orig | ||
|
||
# Created by git when using merge tools for conflicts | ||
*.BACKUP.* | ||
*.BASE.* | ||
*.LOCAL.* | ||
*.REMOTE.* | ||
*_BACKUP_*.txt | ||
*_BASE_*.txt | ||
*_LOCAL_*.txt | ||
*_REMOTE_*.txt | ||
|
||
### Intellij ### | ||
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio, WebStorm and Rider | ||
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839 | ||
|
||
# User-specific stuff | ||
.idea/**/workspace.xml | ||
.idea/**/tasks.xml | ||
.idea/**/usage.statistics.xml | ||
.idea/**/dictionaries | ||
.idea/**/shelf | ||
|
||
# AWS User-specific | ||
.idea/**/aws.xml | ||
|
||
# Generated files | ||
.idea/**/contentModel.xml | ||
|
||
# Sensitive or high-churn files | ||
.idea/**/dataSources/ | ||
.idea/**/dataSources.ids | ||
.idea/**/dataSources.local.xml | ||
.idea/**/sqlDataSources.xml | ||
.idea/**/dynamic.xml | ||
.idea/**/uiDesigner.xml | ||
.idea/**/dbnavigator.xml | ||
|
||
# Gradle | ||
.idea/**/gradle.xml | ||
.idea/**/libraries | ||
|
||
# Gradle and Maven with auto-import | ||
# When using Gradle or Maven with auto-import, you should exclude module files, | ||
# since they will be recreated, and may cause churn. Uncomment if using | ||
# auto-import. | ||
# .idea/artifacts | ||
# .idea/compiler.xml | ||
# .idea/jarRepositories.xml | ||
# .idea/modules.xml | ||
# .idea/*.iml | ||
# .idea/modules | ||
# *.iml | ||
# *.ipr | ||
|
||
# CMake | ||
cmake-build-*/ | ||
|
||
# Mongo Explorer plugin | ||
.idea/**/mongoSettings.xml | ||
|
||
# File-based project format | ||
*.iws | ||
|
||
# IntelliJ | ||
out/ | ||
|
||
# mpeltonen/sbt-idea plugin | ||
.idea_modules/ | ||
|
||
# JIRA plugin | ||
atlassian-ide-plugin.xml | ||
|
||
# Cursive Clojure plugin | ||
.idea/replstate.xml | ||
|
||
# SonarLint plugin | ||
.idea/sonarlint/ | ||
|
||
# Crashlytics plugin (for Android Studio and IntelliJ) | ||
com_crashlytics_export_strings.xml | ||
crashlytics.properties | ||
crashlytics-build.properties | ||
fabric.properties | ||
|
||
# Editor-based Rest Client | ||
.idea/httpRequests | ||
|
||
# Android studio 3.1+ serialized cache file | ||
.idea/caches/build_file_checksums.ser | ||
|
||
### Intellij Patch ### | ||
# Comment Reason: https://github.com/joeblau/gitignore.io/issues/186#issuecomment-215987721 | ||
|
||
# *.iml | ||
# modules.xml | ||
# .idea/misc.xml | ||
# *.ipr | ||
|
||
# Sonarlint plugin | ||
# https://plugins.jetbrains.com/plugin/7973-sonarlint | ||
.idea/**/sonarlint/ | ||
|
||
# SonarQube Plugin | ||
# https://plugins.jetbrains.com/plugin/7238-sonarqube-community-plugin | ||
.idea/**/sonarIssues.xml | ||
|
||
# Markdown Navigator plugin | ||
# https://plugins.jetbrains.com/plugin/7896-markdown-navigator-enhanced | ||
.idea/**/markdown-navigator.xml | ||
.idea/**/markdown-navigator-enh.xml | ||
.idea/**/markdown-navigator/ | ||
|
||
# Cache file creation bug | ||
# See https://youtrack.jetbrains.com/issue/JBR-2257 | ||
.idea/$CACHE_FILE$ | ||
|
||
# CodeStream plugin | ||
# https://plugins.jetbrains.com/plugin/12206-codestream | ||
.idea/codestream.xml | ||
|
||
# Azure Toolkit for IntelliJ plugin | ||
# https://plugins.jetbrains.com/plugin/8053-azure-toolkit-for-intellij | ||
.idea/**/azureSettings.xml | ||
|
||
### Intellij+all ### | ||
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio, WebStorm and Rider | ||
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839 | ||
|
||
# User-specific stuff | ||
|
||
# AWS User-specific | ||
|
||
# Generated files | ||
|
||
# Sensitive or high-churn files | ||
|
||
# Gradle | ||
|
||
# Gradle and Maven with auto-import | ||
# When using Gradle or Maven with auto-import, you should exclude module files, | ||
# since they will be recreated, and may cause churn. Uncomment if using | ||
# auto-import. | ||
# .idea/artifacts | ||
# .idea/compiler.xml | ||
# .idea/jarRepositories.xml | ||
# .idea/modules.xml | ||
# .idea/*.iml | ||
# .idea/modules | ||
# *.iml | ||
# *.ipr | ||
|
||
# CMake | ||
|
||
# Mongo Explorer plugin | ||
|
||
# File-based project format | ||
|
||
# IntelliJ | ||
|
||
# mpeltonen/sbt-idea plugin | ||
|
||
# JIRA plugin | ||
|
||
# Cursive Clojure plugin | ||
|
||
# SonarLint plugin | ||
|
||
# Crashlytics plugin (for Android Studio and IntelliJ) | ||
|
||
# Editor-based Rest Client | ||
|
||
# Android studio 3.1+ serialized cache file | ||
|
||
### Intellij+all Patch ### | ||
# Ignore everything but code style settings and run configurations | ||
# that are supposed to be shared within teams. | ||
|
||
.idea/* | ||
|
||
!.idea/codeStyles | ||
!.idea/runConfigurations | ||
|
||
### Intellij+iml ### | ||
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio, WebStorm and Rider | ||
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839 | ||
|
||
# User-specific stuff | ||
|
||
# AWS User-specific | ||
|
||
# Generated files | ||
|
||
# Sensitive or high-churn files | ||
|
||
# Gradle | ||
|
||
# Gradle and Maven with auto-import | ||
# When using Gradle or Maven with auto-import, you should exclude module files, | ||
# since they will be recreated, and may cause churn. Uncomment if using | ||
# auto-import. | ||
# .idea/artifacts | ||
# .idea/compiler.xml | ||
# .idea/jarRepositories.xml | ||
# .idea/modules.xml | ||
# .idea/*.iml | ||
# .idea/modules | ||
# *.iml | ||
# *.ipr | ||
|
||
# CMake | ||
|
||
# Mongo Explorer plugin | ||
|
||
# File-based project format | ||
|
||
# IntelliJ | ||
|
||
# mpeltonen/sbt-idea plugin | ||
|
||
# JIRA plugin | ||
|
||
# Cursive Clojure plugin | ||
|
||
# SonarLint plugin | ||
|
||
# Crashlytics plugin (for Android Studio and IntelliJ) | ||
|
||
# Editor-based Rest Client | ||
|
||
# Android studio 3.1+ serialized cache file | ||
|
||
### Intellij+iml Patch ### | ||
# Reason: https://github.com/joeblau/gitignore.io/issues/186#issuecomment-249601023 | ||
|
||
*.iml | ||
modules.xml | ||
.idea/misc.xml | ||
*.ipr | ||
|
||
### NetBeans ### | ||
**/nbproject/private/ | ||
**/nbproject/Makefile-*.mk | ||
**/nbproject/Package-*.bash | ||
build/ | ||
nbbuild/ | ||
dist/ | ||
nbdist/ | ||
.nb-gradle/ | ||
|
||
### Gradle ### | ||
.gradle | ||
**/build/ | ||
!src/**/build/ | ||
|
||
# Ignore Gradle GUI config | ||
gradle-app.setting | ||
|
||
# Avoid ignoring Gradle wrapper jar file (.jar files are usually ignored) | ||
!gradle-wrapper.jar | ||
|
||
# Avoid ignore Gradle wrappper properties | ||
!gradle-wrapper.properties | ||
|
||
# Cache of project | ||
.gradletasknamecache | ||
|
||
# Eclipse Gradle plugin generated files | ||
# Eclipse Core | ||
.project | ||
# JDT-specific (Eclipse Java Development Tools) | ||
.classpath | ||
|
||
### Gradle Patch ### | ||
# Java heap dump | ||
*.hprof | ||
/.idea/ | ||
/HELP.md | ||
/src/main/resources/application-local.yml | ||
/src/test/resources/application.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,29 @@ | ||
# springboot-jpa | ||
스프링부트 JPA 위클리미션을 코드리뷰하는 Repository입니다. | ||
# [Project] Springboot JPA Weekly Mission | ||
## 프로젝트 소개 😎 | ||
스프링부트 JPA 위클리미션을 코드 리뷰하는 저장소 입니다. | ||
|
||
## 개발 환경 | ||
- Language : Java 17 | ||
- Framework : Springboot 3.1.2 | ||
- ORM : JPA | ||
- Build Tool : Gradle | ||
- Dev Tool : IntelliJ, Docker | ||
- Test : JUnit 5 | ||
- DB : MySQL, H2 | ||
|
||
### 이번 코드리뷰가 이루어지는 과정 | ||
1. 백둥이끼리 코드리뷰를 진행합니다. | ||
2. 백둥이끼리의 코드리뷰가 마치면, 멘토님에게 2차 리뷰를 요청합니다. | ||
<br/> | ||
2. 백둥이끼리의 코드리뷰가 마치면, 멘토님에게 2차 리뷰를 요청합니다. | ||
|
||
### 과제 번호 | ||
- 미션1 : **2. JPA 소개(단일 엔티티를 이용한 CRUD를 구현)** | ||
- 미션2 : **3. 영속성컨텍스트(customer 엔티티를 이용하여 생명주기 실습)** | ||
- 미션3 : **4-2. 연관관계매핑(order, order_item, item의 연관관계 매핑 실습)** | ||
<br/> | ||
|
||
### 코드리뷰 할 과제 | ||
- 미션 1과 3은 코드리뷰를 진행해봅시다! | ||
- 미션 2의 코드리뷰 진행해도 스킵해도 됩니다. 스킵할 경우 실습해본 코드만 올려보세요 😀 | ||
- 미션 2는 생명주기를 한 번 직접 코딩해보는 정도여서 리뷰는 필요없어도 될 것 같습니다. | ||
<br/> | ||
|
||
### 코드리뷰가 마쳤다면! 만족할 코드가 완성되었다면! Merge! | ||
- merge하면서 conflict가 날 수 있겠죠? Git/Github 특강을 다시보며 해결해봅시다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
plugins { | ||
id 'java' | ||
id 'org.springframework.boot' version '3.1.2' | ||
id 'io.spring.dependency-management' version '1.1.2' | ||
} | ||
|
||
group = 'kr.co' | ||
version = '0.0.1-SNAPSHOT' | ||
|
||
java { | ||
sourceCompatibility = '17' | ||
} | ||
|
||
configurations { | ||
compileOnly { | ||
extendsFrom annotationProcessor | ||
} | ||
} | ||
|
||
repositories { | ||
mavenCentral() | ||
} | ||
|
||
dependencies { | ||
//Web | ||
implementation 'org.springframework.boot:spring-boot-starter-web' | ||
|
||
//Test | ||
testImplementation 'org.springframework.boot:spring-boot-starter-test' | ||
|
||
//JPA | ||
implementation 'org.springframework.boot:spring-boot-starter-data-jpa' | ||
|
||
//Validation | ||
implementation 'org.springframework.boot:spring-boot-starter-validation' | ||
|
||
//Lombok | ||
compileOnly 'org.projectlombok:lombok' | ||
annotationProcessor 'org.projectlombok:lombok' | ||
|
||
//Dev Tool | ||
developmentOnly 'org.springframework.boot:spring-boot-devtools' | ||
|
||
//H2 | ||
runtimeOnly 'com.h2database:h2' | ||
|
||
//MySQL | ||
runtimeOnly 'com.mysql:mysql-connector-j' | ||
} | ||
|
||
tasks.named('test') { | ||
useJUnitPlatform() | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency를 이렇게 나누니까 정말 좋은거 같아요! 배워갑니다 >.<