[4기 박현지] Mission 2: 영속성 컨텍스트 #263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CustomerRepository의 CRUD 메서드 활용
juno-junho
approved these changes
Jul 27, 2023
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| repository.deleteAll(); |
There was a problem hiding this comment.
반복되는 EntityManager 생성을 setup method를 통해서 하는건 어떨까요?
There was a problem hiding this comment.
넵! 적용했습니다~!
refactor: 공통 메서드 https://github.com/beforeeach 메서드로 분리
|
|
||
| transaction.commit(); | ||
|
|
||
| transaction.begin(); |
There was a problem hiding this comment.
삭제에 대한 검증이니 transaction.begin()은 remove() 전에 선언하는것은 어떨까요?
find()는 굳이 transaction 안에 있지 않아도 되니까요..!
There was a problem hiding this comment.
첫 번째 find문은 persist후 commit했을 때 잘 저장됐음을 확인하기 위함이고 현재 begin()은 remove()위에 있는데 혹시 어떤 부분을 말씀하시는 걸까요..?
Comment on lines
18
to
22
| @Autowired | ||
| CustomerRepository repository; | ||
|
|
||
| @Autowired | ||
| EntityManagerFactory emf; |
There was a problem hiding this comment.
CustomerRepository의 메서드로도 가능한데 강의 때 영속성 컨텍스트의 생명주기에 대해 학습해서 EntityManagerFactory를 사용해서 명시적으로 구현헀습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
영속성 컨텍스트 관련 테스트 작성
👩💻 요구 사항과 구현 내용
✅ 피드백 반영사항
✅ PR 포인트 & 궁금한 점