PCP: PMDA: Introduce new PMDA for RDS #2230
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # | ||
| # Copyright (c) 2025 Oracle and/or its affiliates. | ||
| # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| # | ||
| # This program is free software; you can redistribute it and/or modify it | ||
| # under the terms of the GNU General Public License as published by the | ||
| # Free Software Foundation; either version 2 of the License, or (at your | ||
| # option) any later version. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, but | ||
| # WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY | ||
| # or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| # for more details. | ||
| # | ||
|
|
||
| TOPDIR = ../../.. | ||
| include $(TOPDIR)/src/include/builddefs | ||
|
|
||
| IAM = rds | ||
| PYSCRIPT = pmda$(IAM).python | ||
| LDIRT = domain.h root pmns $(IAM).log | ||
| DOMAIN = GLUSTER | ||
|
|
||
| PMDAADMDIR = $(PCP_PMDASADM_DIR)/$(IAM) | ||
| PMDATMPDIR = $(PCP_PMDAS_DIR)/$(IAM) | ||
|
|
||
| MAN_SECTION = 1 | ||
| MAN_PAGES = pmda$(IAM).$(MAN_SECTION) | ||
| MAN_DEST = $(PCP_MAN_DIR)/man$(MAN_SECTION) | ||
|
|
||
| default_pcp default: build-me | ||
|
|
||
| include $(BUILDRULES) | ||
|
|
||
| ifeq "$(HAVE_PYTHON)" "true" | ||
| build-me: check_domain | ||
| install_pcp install: default | ||
| $(INSTALL) -m 755 -d $(PMDAADMDIR) | ||
| $(INSTALL) -m 755 -d $(PMDATMPDIR) | ||
| $(INSTALL) -m 755 -t $(PMDATMPDIR) Install Remove $(PYSCRIPT) $(PMDAADMDIR) | ||
| @$(INSTALL_MAN) | ||
| else | ||
| build-me: | ||
| install_pcp install: | ||
| @$(INSTALL_MAN) | ||
| endif | ||
|
|
||
| check_domain: ../../pmns/stdpmid | ||
| $(DOMAIN_PYTHONRULE) | ||
|
|
||
| check:: $(MAN_PAGES) | ||
|
There was a problem hiding this comment. There's a missing 'check' target here to run pylint on all the python code. |
||
| $(MANLINT) $^ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # | ||
| # Copyright (c) 2025 Oracle and/or its affiliates. | ||
| # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| # | ||
| # This program is free software; you can redistribute it and/or modify it | ||
| # under the terms of the GNU General Public License as published by the | ||
| # Free Software Foundation; either version 2 of the License, or (at your | ||
| # option) any later version. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, but | ||
| # WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY | ||
| # or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| # for more details. | ||
| # | ||
|
|
||
| . $PCP_DIR/etc/pcp.env | ||
| . $PCP_SHARE_DIR/lib/pmdaproc.sh | ||
|
|
||
| iam=rds | ||
| python_opt=true | ||
| daemon_opt=false | ||
|
|
||
| # Prepare PMDA Python files (needed for easier packaging) | ||
| $PCP_PYTHON_PROG $PCP_PMDAS_DIR/rds/pyprep | ||
|
There was a problem hiding this comment. Remove this - see notes later regarding this script. |
||
|
|
||
| # | ||
| # See pmcd(1) man page. PMDA starts up in the "not ready" state. | ||
| # When it has finished starting up, it sends a PM_ERR_PMDAREADY | ||
| # error PDU to PMCD to indicate it's ready to start processing | ||
| # requests. | ||
|
|
||
| ipc_prot="binary notready" | ||
| pmdaSetup | ||
| pmdaInstall | ||
| exit | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # | ||
| # Copyright (c) 2025 Oracle and/or its affiliates. | ||
| # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| # | ||
| # This program is free software; you can redistribute it and/or modify it | ||
| # under the terms of the GNU General Public License as published by the | ||
| # Free Software Foundation; either version 2 of the License, or (at your | ||
| # option) any later version. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, but | ||
| # WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY | ||
| # or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| # for more details. | ||
| # | ||
| # Remove the rds PMDA | ||
| # | ||
|
|
||
| # source the PCP configuration environment variables | ||
| . $PCP_DIR/etc/pcp.env | ||
|
|
||
| # Get the common procedures and variable assignments | ||
| # | ||
| . $PCP_SHARE_DIR/lib/pmdaproc.sh | ||
|
|
||
| # The name of the PMDA | ||
| # | ||
| iam=rds | ||
|
|
||
| # Do it | ||
| # | ||
| pmdaSetup | ||
| pmdaRemove | ||
|
|
||
|
|
||
| exit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| #define RDS 256 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to expand RDS the acronym here (like PCP is) in the Summary. (same change needed in redhat.spec below)