Skip to content

fix: fix typo #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: fix typo #3557

wants to merge 1 commit into from

Conversation

kagol
Copy link
Member

@kagol kagol commented Jul 9, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Corrected the Chinese text from "远程登陆" to "远程登录" across multiple menu options and related examples for consistency.
  • Tests
    • Updated test assertions and test data to reflect the corrected label text.

Copy link

coderabbitai bot commented Jul 9, 2025

Walkthrough

This update standardizes the Chinese text from "远程登陆" to "远程登录" across multiple demo components, test files, and a code comment. All changes are textual corrections, with no modifications to logic, structure, or control flow in any affected files.

Changes

Files (Grouped) Change Summary
examples/sites/demos/pc/app/action-menu/basic-usage.vue
examples/sites/demos/pc/app/action-menu/basic-usage-composition-api.vue
examples/sites/demos/pc/app/action-menu/card-mode.vue
examples/sites/demos/pc/app/action-menu/card-mode-composition-api.vue
examples/sites/demos/pc/app/action-menu/events.vue
examples/sites/demos/pc/app/action-menu/events-composition-api.vue
examples/sites/demos/pc/app/action-menu/max-show-num.vue
examples/sites/demos/pc/app/action-menu/max-show-num-composition-api.vue
examples/sites/demos/pc/app/action-menu/more-text.vue
examples/sites/demos/pc/app/action-menu/more-text-composition-api.vue
examples/sites/demos/pc/app/action-menu/popper-class.vue
examples/sites/demos/pc/app/action-menu/popper-class-composition-api.vue
examples/sites/demos/pc/app/action-menu/slot-item.vue
examples/sites/demos/pc/app/action-menu/slot-item-composition-api.vue
examples/sites/demos/pc/app/action-menu/spacing.vue
examples/sites/demos/pc/app/action-menu/spacing-composition-api.vue
examples/sites/demos/pc/app/action-menu/text-field.vue
examples/sites/demos/pc/app/action-menu/text-field-composition-api.vue
Corrected menu option label from "远程登陆" to "远程登录" in options arrays or name fields.
examples/sites/demos/pc/app/action-menu/disabled.vue
examples/sites/demos/pc/app/action-menu/disabled-composition-api.vue
examples/sites/demos/pc/app/action-menu/icon.vue
examples/sites/demos/pc/app/action-menu/icon-composition-api.vue
Updated "远程登陆" to "远程登录" in two places within options/options1 arrays.
packages/renderless/src/logout/index.ts Corrected a comment from "登陆后刷新页面" to "登录后刷新页面".
examples/sites/demos/pc/app/action-menu/text-field.spec.ts
packages/vue/src/action-menu/tests/action-menu.test.tsx
Updated test assertions/data from "远程登陆" to "远程登录".

Poem

🐇
A hop, a skip, a label anew,
"远程登录" shines in every view!
From menus and tests to comments so neat,
The bunny ensures the wording’s complete.
With every patch, the garden grows bright—
Corrected with care, and all text is right!
🌱✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

examples/sites/demos/pc/app/action-menu/basic-usage-composition-api.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

examples/sites/demos/pc/app/action-menu/card-mode-composition-api.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

examples/sites/demos/pc/app/action-menu/card-mode.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

  • 22 others
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Jul 9, 2025
Copy link

Walkthrough

This pull request addresses a typo correction across multiple files in the project. The typo involves changing the Chinese term "远程登陆" to "远程登录", ensuring consistency and accuracy in the language used throughout the codebase.

Changes

Files Summary
examples/sites/demos/pc/app/action-menu/*.vue Corrected typo from '远程登陆' to '远程登录' in various demo files.
packages/renderless/src/logout/index.ts Corrected typo in a comment from '登陆' to '登录'.
packages/vue/src/action-menu/tests/action-menu.test.tsx Corrected typo from '远程登陆' to '远程登录' in test file.

@@ -8,7 +8,7 @@ import { TinyActionMenu } from '@opentiny/vue'
const options = ref([
{
label: '远程登陆'
label: '远程登录'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -13,7 +13,7 @@ export default {
return {
options: [
{
label: '远程登陆'
label: '远程登录'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -9,7 +9,7 @@ import { iconWebPlus, iconSuccessful, iconCloseSquare } from '@opentiny/vue-icon
const options = ref([
{
label: '远程登陆',
label: '远程登录',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -14,7 +14,7 @@ export default {
return {
options: [
{
label: '远程登陆',
label: '远程登录',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -15,7 +15,7 @@ import { iconWebPlus, iconSuccessful, iconCloseSquare } from '@opentiny/vue-icon
const options = ref([
{
label: '远程登陆'
label: '远程登录'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -38,7 +38,7 @@ const options = ref([
const options1 = ref([
{
label: '远程登陆',
label: '远程登录',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -20,7 +20,7 @@ export default {
return {
options: [
{
label: '远程登陆'
label: '远程登录'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -43,7 +43,7 @@ export default {
],
options1: [
{
label: '远程登陆',
label: '远程登录',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -15,7 +15,7 @@ import { TinyActionMenu, TinyNotify } from '@opentiny/vue'
const options = ref([
{
label: '远程登陆'
label: '远程登录'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -20,7 +20,7 @@ export default {
return {
options: [
{
label: '远程登陆'
label: '远程登录'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -23,7 +23,7 @@ import { iconWebPlus, iconSuccessful, iconShutdown, iconEllipsis } from '@openti
const options = ref([
{
label: '远程登陆',
label: '远程登录',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -45,7 +45,7 @@ const options = ref([
const options1 = ref([
{
label: '远程登陆'
label: '远程登录'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

@@ -27,7 +27,7 @@ export default {
return {
options: [
{
label: '远程登陆',
label: '远程登录',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo from '远程登陆' to '远程登录'.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
examples/sites/demos/pc/app/action-menu/max-show-num-composition-api.vue (1)

9-26: Consider extracting hard-coded labels into a shared i18n source.

You needed to touch dozens of demo files for a single typo. Centralising the strings (e.g. via JSON locale files or a small constants.ts) would avoid this sweeping edit the next time a wording change is required.

examples/sites/demos/pc/app/action-menu/disabled-composition-api.vue (1)

16-60: Same i18n centralisation suggestion applies.

Duplicated literal strings across options and options1 could be de-duplicated via a small helper or locale file.

examples/sites/demos/pc/app/action-menu/disabled.vue (1)

23-23: Consistent terminology fix looks good

The typo is corrected uniformly in both option arrays – no further issues spotted.

If “远程登录” is reused elsewhere, consider extracting it into an i18n message or a shared constant to avoid future drift.

Also applies to: 46-46

examples/sites/demos/pc/app/action-menu/slot-item.vue (1)

23-23: Label typo resolved

The menu item text is now consistent with other demos.

Same remark as above: centralise static labels via i18n to prevent scattered string updates.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9f75d0 and 2cea94b.

📒 Files selected for processing (25)
  • examples/sites/demos/pc/app/action-menu/basic-usage-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/basic-usage.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/card-mode-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/card-mode.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/disabled-composition-api.vue (2 hunks)
  • examples/sites/demos/pc/app/action-menu/disabled.vue (2 hunks)
  • examples/sites/demos/pc/app/action-menu/events-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/events.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/icon-composition-api.vue (2 hunks)
  • examples/sites/demos/pc/app/action-menu/icon.vue (2 hunks)
  • examples/sites/demos/pc/app/action-menu/max-show-num-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/max-show-num.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/more-text-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/more-text.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/popper-class-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/popper-class.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/slot-item-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/slot-item.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/spacing-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/spacing.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/text-field-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/text-field.spec.ts (1 hunks)
  • examples/sites/demos/pc/app/action-menu/text-field.vue (1 hunks)
  • packages/renderless/src/logout/index.ts (1 hunks)
  • packages/vue/src/action-menu/__tests__/action-menu.test.tsx (1 hunks)
🧰 Additional context used
🧠 Learnings (17)
examples/sites/demos/pc/app/action-menu/spacing-composition-api.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/events.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/card-mode-composition-api.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/disabled-composition-api.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/basic-usage-composition-api.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/max-show-num-composition-api.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/popper-class-composition-api.vue (2)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-heatmap/src/chart-heatmap.vue:38-40
Timestamp: 2024-11-25T03:43:19.322Z
Learning: 在 Vue.js 组件(如 `chart-heatmap.vue`)中,使用来自 `chart-core` 的 `huiChartOption` 来管理图表选项,不要在 `data()` 中声明 `option`。
examples/sites/demos/pc/app/action-menu/events-composition-api.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/max-show-num.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/icon-composition-api.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/text-field.vue (3)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-histogram/src/chart-histogram.vue:33-36
Timestamp: 2024-11-25T03:43:05.285Z
Learning: 在 Tiny Vue 代码库中,使用 `chart-core` 中的 `huiChartOption` 的组件,不应在其 `data` 中定义 `huiChartOption` 或 `option`,而是应该依赖 `chart-core` 提供的 `huiChartOption`。
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-heatmap/src/chart-heatmap.vue:38-40
Timestamp: 2024-11-25T03:43:19.322Z
Learning: 在 Vue.js 组件(如 `chart-heatmap.vue`)中,使用来自 `chart-core` 的 `huiChartOption` 来管理图表选项,不要在 `data()` 中声明 `option`。
examples/sites/demos/pc/app/action-menu/slot-item.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/slot-item-composition-api.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/text-field-composition-api.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/more-text.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/basic-usage.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
examples/sites/demos/pc/app/action-menu/icon.vue (1)
Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中,当使用`chart-core`时,应删除错误的`option`定义,使用`chart-core`中的`huiChartOption`。
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (23)
examples/sites/demos/pc/app/action-menu/text-field.spec.ts (1)

11-11: ✅ Assertion updated & no outdated typos found

  • The test in examples/sites/demos/pc/app/action-menu/text-field.spec.ts now correctly asserts ‘远程登录’.
  • A repo-wide search confirms there are no remaining occurrences of “远程登陆”.
examples/sites/demos/pc/app/action-menu/spacing-composition-api.vue (1)

15-15: Label typo fixed

The option label is now the correct “远程登录”. No further issues.

examples/sites/demos/pc/app/action-menu/more-text.vue (1)

16-16: Consistent wording

Label corrected to “远程登录”, keeping demo text consistent across files.

examples/sites/demos/pc/app/action-menu/max-show-num.vue (1)

16-16: Typo correction acknowledged

The display text is now accurate; change is purely cosmetic.

examples/sites/demos/pc/app/action-menu/events.vue (1)

23-23: String fix applied here as well

Good catch—label now matches the other demos.

examples/sites/demos/pc/app/action-menu/events-composition-api.vue (1)

18-18: Typo correction looks good

The label text has been corrected from “远程登陆” to “远程登录”. No functional impact.

examples/sites/demos/pc/app/action-menu/basic-usage-composition-api.vue (1)

11-11: Consistent typo fix

Same text correction as in other demos; change is accurate and harmless.

examples/sites/demos/pc/app/action-menu/basic-usage.vue (1)

16-16: Label updated correctly

The hard-coded option text is now spelled correctly.

examples/sites/demos/pc/app/action-menu/popper-class-composition-api.vue (1)

11-11: LGTM

Textual correction only; component behaviour unchanged.

examples/sites/demos/pc/app/action-menu/card-mode-composition-api.vue (1)

12-12: Fix applied consistently

Typo fixed; no further action required.

examples/sites/demos/pc/app/action-menu/max-show-num-composition-api.vue (1)

9-13: LGTM – typo fixed consistently.

Label corrected to “远程登录”, no logic touched.

examples/sites/demos/pc/app/action-menu/more-text-composition-api.vue (1)

9-13: LGTM – typo corrected.

examples/sites/demos/pc/app/action-menu/spacing.vue (1)

18-22: LGTM – string fix only.

examples/sites/demos/pc/app/action-menu/disabled-composition-api.vue (1)

16-19: LGTM – both option arrays updated.

No behavioural impact; matches other demo files.

Also applies to: 40-43

examples/sites/demos/pc/app/action-menu/card-mode.vue (1)

15-19: LGTM – corrected wording.

examples/sites/demos/pc/app/action-menu/slot-item-composition-api.vue (1)

17-17: Typo fixed – label now reads correctly

The replacement of “远程登陆” with “远程登录” fixes the common-usage typo and keeps wording consistent with the rest of the demos.

examples/sites/demos/pc/app/action-menu/popper-class.vue (1)

16-16: Textual correction is correct and consistent

The option label has been standardised to “远程登录”, matching other demo and test files. No further action needed.

packages/vue/src/action-menu/__tests__/action-menu.test.tsx (1)

9-9: Test data updated to match UI copy

The test fixture now aligns with the corrected menu label. Tests should continue to pass without changes to assertions.

examples/sites/demos/pc/app/action-menu/text-field.vue (1)

16-16: Corrected Chinese wording

The typo fix (“登录” vs “登陆”) maintains consistency across demos and adheres to standard terminology.

examples/sites/demos/pc/app/action-menu/text-field-composition-api.vue (1)

11-11: Consistent wording fix applied

The Composition-API variant now uses the same corrected text as all other files; no logic impacted.

packages/renderless/src/logout/index.ts (1)

100-102: Minor comment typo fixed

The inline comment now uses the right character. Nothing else changed.

examples/sites/demos/pc/app/action-menu/icon-composition-api.vue (1)

26-26: String correction verified

Both reactive arrays reflect the correct wording; no functional impact.

Also applies to: 48-48

examples/sites/demos/pc/app/action-menu/icon.vue (1)

30-30: Typo corrected consistently

Label text fixed in both arrays; demo logic untouched.

Also applies to: 51-51

@zzcr
Copy link
Member

zzcr commented Jul 9, 2025

有个测试用例没过哈

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


There is a test case that has not been passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants