8357064: cds/appcds/ArchiveRelocationTest.java failed with missing expected output

[calvinccheung]

The cds/appcds/ArchiveRelocationTest.java test failed intermittently on Windows when the "Failed to reserve spaces" error occurred. A fix is to relax the check of the expected output; just to check either one of the expected output exists.

Testing: ran the "hotspot_runtime" test group 60 times on Windows with the -XX:+UseParallelGC -XX:+UseNUMA VM options.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357064: cds/appcds/ArchiveRelocationTest.java failed with missing expected output (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26075/head:pull/26075
$ git checkout pull/26075

Update a local copy of the PR:
$ git checkout pull/26075
$ git pull https://git.openjdk.org/jdk.git pull/26075/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26075

View PR using the GUI difftool:
$ git pr show -t 26075

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26075.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357064: cds/appcds/ArchiveRelocationTest.java failed with missing expected output

Reviewed-by: shade, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 282ee40: 8359366: RunThese30M.java EXCEPTION_ACCESS_VIOLATION in JvmtiBreakpoints::clearall_in_class_at_safepoint
• e7a4500: 8359707: Add classfile modification code to RedefineClassHelper
• 38f59f8: 8358179: Performance regression in Math.cbrt
• ... and 13 more: https://git.openjdk.org/jdk/compare/9d518b3213af7c60cb604138a2c4022181bb2daa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3269ce32)

[iklam]

LGTM

[calvinccheung]

Thanks @shipilev @iklam for the review.

/integrate

[openjdk]

Going to push as commit 534d2b3.
Since your change was applied there have been 18 commits pushed to the master branch:

• e9a62d7: 8361125: Fix typo in onTradAbsence
• 13a3927: 8359870: JVM crashes in AccessInternal::PostRuntimeDispatch
• 282ee40: 8359366: RunThese30M.java EXCEPTION_ACCESS_VIOLATION in JvmtiBreakpoints::clearall_in_class_at_safepoint
• ... and 15 more: https://git.openjdk.org/jdk/compare/9d518b3213af7c60cb604138a2c4022181bb2daa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 534d2b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.