8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

[jaikiran]

Can I please get a review of this backport of a test-only fix?

This backports the fix for https://bugs.openjdk.org/browse/JDK-8359337 into JDK 25. The original fix was integrated into mainline a few minutes back #26052. Backporting this fix should help prevent failure of these tests on macOS hosts which have proxies configured.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Iris Clark (@irisclark - Reviewer)
• Joe Wang (@JoeWang-Java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26065/head:pull/26065
$ git checkout pull/26065

Update a local copy of the PR:
$ git checkout pull/26065
$ git pull https://git.openjdk.org/jdk.git pull/26065/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26065

View PR using the GUI difftool:
$ git pr show -t 26065

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26065.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

Reviewed-by: dfuchs, iris, joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (630421cf)

[dfuch]

Look reasonable to me - though strictly speaking tests that fiddle with the global configuration should be run in /othervm. This seems OK without /othervm as long as tests are not run concurrently in the same VM.

[dfuch]

Maybe wait for @JoeWang-Java to approve before pushing.

[jaikiran]

This seems OK without /othervm as long as tests are not run concurrently in the same VM.

jtreg guarantees that a agentvm is only used for one single action. So the same JVM will never run more than one test concurrently.

[jaikiran]

So the same JVM will never run more than one test concurrently.

Just for my own peace of mind I looked up the jtreg FAQ to be sure it specifies this behaviour. The FAQ here says https://openjdk.org/jtreg/faq.html#how-do-i-specify-whether-to-run-tests-concurrently

(jtreg never runs multiple tests at the same time in any one JVM.)

[irisclark]

Confirmed changes are the same of those already pushed to the master branch.

[JoeWang-Java]

Thanks Jaikiran.

[jaikiran]

Thank you all for the reviews. tier1, tier2 and tier3 tests against JDK 25 with this backport went fine. I'll integrate this now.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 554e38d.

[openjdk]

@jaikiran Pushed as commit 554e38d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.