8361180: Disable CompiledDirectCall verification with -VerifyInlineCaches

[shipilev]

Missed the spot when doing JDK-8360867. There is a path from GC that calls into IC verification when cleaning the caches. See nmethod::cleanup_inline_caches_impl. It does verification per callsite, and does the whole thing during parallel GC cleanup, which is STW at least in G1. This gets expensive for CTW scenarios. We should wrap that under the same flag introduced by JDK-8360867.

Motivational improvements:

$ time CONF=linux-x86_64-server-fastdebug make test TEST=applications/ctw/modules/

# Current mainline
real	3m59.274s
user	68m9.663s
sys	5m19.026s

# This PR
real	3m49.118s
user	65m37.962s
sys	5m15.441s

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361180: Disable CompiledDirectCall verification with -VerifyInlineCaches (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26063/head:pull/26063
$ git checkout pull/26063

Update a local copy of the PR:
$ git checkout pull/26063
$ git pull https://git.openjdk.org/jdk.git pull/26063/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26063

View PR using the GUI difftool:
$ git pr show -t 26063

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26063.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361180: Disable CompiledDirectCall verification with -VerifyInlineCaches

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 055d2ff: 8361215: Add AOT test case: verification constraint classes are excluded
• 2bff8e0: 8360462: [macosx] row selection not working with Ctrl+Shift+Down/Up in AquaL&F
• c6448dc: 8361086: JVMCIGlobals::check_jvmci_flags_are_consistent has incorrect format string
• ... and 17 more: https://git.openjdk.org/jdk/compare/cd6caedd0a3c9ebd4c8c57e64f62b60161c5cd7c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a97c9104)

[vnkozlov]

Trivial.

[TobiHartmann]

Looks good to me too.

[shipilev]

Thanks! Here goes.

/integrate

[openjdk]

Going to push as commit 1ac7489.
Since your change was applied there have been 20 commits pushed to the master branch:

• 055d2ff: 8361215: Add AOT test case: verification constraint classes are excluded
• 2bff8e0: 8360462: [macosx] row selection not working with Ctrl+Shift+Down/Up in AquaL&F
• c6448dc: 8361086: JVMCIGlobals::check_jvmci_flags_are_consistent has incorrect format string
• ... and 17 more: https://git.openjdk.org/jdk/compare/cd6caedd0a3c9ebd4c8c57e64f62b60161c5cd7c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 1ac7489.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.