Skip to content

8360887: (fs) Files.getFileAttributeView returns unusable FileAttributeView if UserDefinedFileAttributeView unavailable (aix) #26058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 1, 2025

Clean backport of JDK-8360887.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360887: (fs) Files.getFileAttributeView returns unusable FileAttributeView if UserDefinedFileAttributeView unavailable (aix) (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26058/head:pull/26058
$ git checkout pull/26058

Update a local copy of the PR:
$ git checkout pull/26058
$ git pull https://git.openjdk.org/jdk.git pull/26058/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26058

View PR using the GUI difftool:
$ git pr show -t 26058

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26058.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360887: (fs) Files.getFileAttributeView returns unusable FileAttributeView if UserDefinedFileAttributeView unavailable (aix)

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0572b6ece7a77d13d23ac0c6d72d4fe5d5f0d944 8360887: (fs) Files.getFileAttributeView returns unusable FileAttributeView if UserDefinedFileAttributeView unavailable (aix) Jul 1, 2025
@openjdk
Copy link

openjdk bot commented Jul 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 1, 2025
@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jul 1, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 1, 2025
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!

@AlanBateman
Copy link
Contributor

The change in main line will need follow-up changes so I think hold off on any JDK 25 back ports for now.

@TheRealMDoerr
Copy link
Contributor Author

I'll wait until the follow-up is ready. Thanks, Alan!

@TheRealMDoerr
Copy link
Contributor Author

Follow-up is integrated. I'll do the backport and test it on top of this after
/integrate

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

Going to push as commit a98a5e5.
Since your change was applied there have been 3 commits pushed to the jdk25 branch:

  • b245c51: 8359436: AOTCompileEagerly should not be diagnostic
  • 0a151c6: 8358179: Performance regression in Math.cbrt
  • 554e38d: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 2, 2025
@openjdk openjdk bot closed this Jul 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@TheRealMDoerr Pushed as commit a98a5e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants