Skip to content

8361115: javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException #26056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Jul 1, 2025

Issue:
javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException whenever a test failure occurs.
This causes unnecessary extra attention in CI systems and triggers task failures as throwing an Error will write the error message to System.err and the CI system will detect it as an 'Error' and fails the task eventually.
But this is just a normal test failure only and just need to throw 'RuntimeException' and no need to throw an 'Error'.

Fix:
Replace 'Error' with 'RuntimeException'

Testing:
Tested using mach5 in all the available platforms.
Tested manually the negative (failure) condition also and verified that its throwing 'RuntimeException' in cases of failure.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361115: javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26056/head:pull/26056
$ git checkout pull/26056

Update a local copy of the PR:
$ git checkout pull/26056
$ git pull https://git.openjdk.org/jdk.git pull/26056/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26056

View PR using the GUI difftool:
$ git pr show -t 26056

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26056.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2025

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 1, 2025
@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 1, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant