8361115: javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException #26056
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException whenever a test failure occurs.
This causes unnecessary extra attention in CI systems and triggers task failures as throwing an Error will write the error message to System.err and the CI system will detect it as an 'Error' and fails the task eventually.
But this is just a normal test failure only and just need to throw 'RuntimeException' and no need to throw an 'Error'.
Fix:
Replace 'Error' with 'RuntimeException'
Testing:
Tested using mach5 in all the available platforms.
Tested manually the negative (failure) condition also and verified that its throwing 'RuntimeException' in cases of failure.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26056/head:pull/26056
$ git checkout pull/26056
Update a local copy of the PR:
$ git checkout pull/26056
$ git pull https://git.openjdk.org/jdk.git pull/26056/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26056
View PR using the GUI difftool:
$ git pr show -t 26056
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26056.diff
Using Webrev
Link to Webrev Comment