Skip to content

8361112: Use exact float -> Float16 conversion method in Float16 tests #26055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Jul 1, 2025

Small test enhancement to make the test cases more robust to accidental rounding in float -> Float16 conversions.

A method with this functionality may be added to the API in the future (JDK-8341260).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361112: Use exact float -> Float16 conversion method in Float16 tests (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26055/head:pull/26055
$ git checkout pull/26055

Update a local copy of the PR:
$ git checkout pull/26055
$ git pull https://git.openjdk.org/jdk.git pull/26055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26055

View PR using the GUI difftool:
$ git pr show -t 26055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26055.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2025

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361112: Use exact float -> Float16 conversion method in Float16 tests

Reviewed-by: liach, rgiulietti

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8361112: Use exact float -> Float16 conversion method in Float16 tests 8361112: Use exact float -> Float16 conversion method in Float16 tests Jul 1, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 1, 2025
@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@jddarcy To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

*/
private static Float16 valueOfExact(float f) {
Float16 f16 = valueOf(f);
if (Float.compare(f16.floatValue(), f) != 0 ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (Float.compare(f16.floatValue(), f) != 0 ) {
if (Float.compare(f16.floatValue(), f) != 0) {

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 1, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 2, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants