-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361101: AOTCodeAddressTable::_stubs_addr not initialized/freed properly #26053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ashutosh Mehra <asmehra@redhat.com>
👋 Welcome back asmehra! A progress list of the required criteria for merging this PR into |
@ashu-mehra This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 33 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@ashu-mehra The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@vnkozlov can you please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but please wait with integration - I am working on merge from mainline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that this is for mainline. Approved.
Yes, it is trivial. |
Please reivew this patch to fix initialization and freeing of
AOTCodeAddressTable::_stubs_addr
. Changes are trivialProgress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26053/head:pull/26053
$ git checkout pull/26053
Update a local copy of the PR:
$ git checkout pull/26053
$ git pull https://git.openjdk.org/jdk.git pull/26053/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26053
View PR using the GUI difftool:
$ git pr show -t 26053
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26053.diff
Using Webrev
Link to Webrev Comment