8361086: JVMCIGlobals::check_jvmci_flags_are_consistent has incorrect format string

[kimbarrett]

Please review this trivial fix of a format string. The value being printed is
TieredStopAtLevel, which is of type intx, so "%zd" should be used instead of "%d".

Testing: mach5 tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361086: JVMCIGlobals::check_jvmci_flags_are_consistent has incorrect format string (Bug - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Manuel Hässig (@mhaessig - Committer)
• Yudi Zheng (@mur47x111 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26051/head:pull/26051
$ git checkout pull/26051

Update a local copy of the PR:
$ git checkout pull/26051
$ git pull https://git.openjdk.org/jdk.git pull/26051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26051

View PR using the GUI difftool:
$ git pr show -t 26051

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26051.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361086: JVMCIGlobals::check_jvmci_flags_are_consistent has incorrect format string

Reviewed-by: kvn, mhaessig, yzheng

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 7583a7b: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected
• e85c7d0: 8360790: G1: Improve HRRSStatsIter name
• eec1153: 8361056: Parallel: Use correct is_par argument in ScavengeRootsTask
• ... and 14 more: https://git.openjdk.org/jdk/compare/240541e1c1e3aee633da08e7d12117b8ea38b8f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kimbarrett The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (71bcd023)

[vnkozlov]

Or we can cast it to (int). Or we can change flag's declaration to int type.

[kimbarrett]

Or we can cast it to (int). Or we can change flag's declaration to int type.

I think it's better to change the format string than to cast the value. If we
later change the value type we'll (hopefully by then) get an appropriate
warning about needing to change the format string again. Adding a cast now
becomes a useless or otherwise confusing cast (that is hard to find, because
that's the nature of casts) after a change of type.

I tried changing the type of the option to int and that got messy, because
there are a number of places that are accessing it by name from Java as an
intx, such as using WhiteBox::getIntxVMFlag. I wasn't entirely confident I'd
found all of them, since I was getting into unfamiliar code.

[vnkozlov]

Thank you for checking other solutions.

Current fix is good.

[mhaessig]

Looks good and trivial to me.

[mur47x111]

LGTM

[kimbarrett]

Thanks for reviews @vnkozlov , @mhaessig , and @mur47x111

[kimbarrett]

/integrate

[openjdk]

Going to push as commit c6448dc.
Since your change was applied there have been 28 commits pushed to the master branch:

• 1703915: 8361085: MemoryReserver log_on_large_pages_failure has incorrect format usage
• a910b20: 8346914: UB issue in scalbnA
• 7d7e60c: 8360164: AOT cache creation crashes in ~ThreadTotalCPUTimeClosure()
• ... and 25 more: https://git.openjdk.org/jdk/compare/240541e1c1e3aee633da08e7d12117b8ea38b8f4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit c6448dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.