8361085: MemoryReserver log_on_large_pages_failure has incorrect format usage

[kimbarrett]

Please review this fix of an incorrect format usage.

The function calls jio_snprintf to format a message into a buffer. That
message includes printing a pointer using PTR_FORMAT, but isn't using the
p2i helper function. Fixing that is just a matter of using that helper.

However, there's no need to use jio_snprintf here, as the resulting message
is then just passed to warning, which can handle output formatting directly.
So we also move the formatting to the warning call, and remove the use of
jio_snprintf. Note that calling warning without the p2i would have
produced a compiler warning about the incorrect format usage.

Testing: mach5 tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361085: MemoryReserver log_on_large_pages_failure has incorrect format usage (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26050/head:pull/26050
$ git checkout pull/26050

Update a local copy of the PR:
$ git checkout pull/26050
$ git pull https://git.openjdk.org/jdk.git pull/26050/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26050

View PR using the GUI difftool:
$ git pr show -t 26050

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26050.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361085: MemoryReserver log_on_large_pages_failure has incorrect format usage

Reviewed-by: stefank, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 282ee40: 8359366: RunThese30M.java EXCEPTION_ACCESS_VIOLATION in JvmtiBreakpoints::clearall_in_class_at_safepoint
• e7a4500: 8359707: Add classfile modification code to RedefineClassHelper
• 38f59f8: 8358179: Performance regression in Math.cbrt
• ... and 19 more: https://git.openjdk.org/jdk/compare/240541e1c1e3aee633da08e7d12117b8ea38b8f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f3b5014d)

[dholmes-ora]

Looks good.

It is strange that this pattern of doing a warning used to be used in a few places, even though warning has always been able to handle the formatting directly.

[kimbarrett]

Thanks for reviews @stefank and @dholmes-ora

[kimbarrett]

/integrate

[openjdk]

Going to push as commit 1703915.
Since your change was applied there have been 27 commits pushed to the master branch:

• a910b20: 8346914: UB issue in scalbnA
• 7d7e60c: 8360164: AOT cache creation crashes in ~ThreadTotalCPUTimeClosure()
• 534d2b3: 8357064: cds/appcds/ArchiveRelocationTest.java failed with missing expected output
• ... and 24 more: https://git.openjdk.org/jdk/compare/240541e1c1e3aee633da08e7d12117b8ea38b8f4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit 1703915.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.