Skip to content

8361040: compiler/codegen/TestRedundantLea.java#StringInflate fails with failed IR rules #26046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Jun 30, 2025

TestRedundantLea.java#StringInflate failed on Alpine Linux because fewer DecodeHeapOop_not_nulls than expected are generated even though the expected reduction is still present. This PR fixes this.

Unfortunately, this fix makes the test less precise. I filed JDK-8361045 to fix this when the IR-framework allows for it.

Testing:

  • Github Actions
  • tier1, tier2 plus Oracle internal testing
  • TestRedundantLea.java on Alpine Linux

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361040: compiler/codegen/TestRedundantLea.java#StringInflate fails with failed IR rules (Bug - P4)

Contributors

  • Matthias Baesken <mbaesken@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26046/head:pull/26046
$ git checkout pull/26046

Update a local copy of the PR:
$ git checkout pull/26046
$ git pull https://git.openjdk.org/jdk.git pull/26046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26046

View PR using the GUI difftool:
$ git pr show -t 26046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26046.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2025

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 30, 2025

@mhaessig The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 30, 2025
@MBaesken
Copy link
Member

MBaesken commented Jul 1, 2025

With your patch included, the issue is gone on our Linux Alpine test machine.

@mhaessig
Copy link
Contributor Author

mhaessig commented Jul 1, 2025

@MBaesken, thank you for testing.

/contributor add @MBaesken

@mhaessig mhaessig marked this pull request as ready for review July 1, 2025 12:44
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 1, 2025
@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@mhaessig
Contributor Matthias Baesken <mbaesken@openjdk.org> successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 1, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants