8361040: compiler/codegen/TestRedundantLea.java#StringInflate fails with failed IR rules #26046
+6
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestRedundantLea.java#StringInflate
failed on Alpine Linux because fewerDecodeHeapOop_not_null
s than expected are generated even though the expected reduction is still present. This PR fixes this.Unfortunately, this fix makes the test less precise. I filed JDK-8361045 to fix this when the IR-framework allows for it.
Testing:
TestRedundantLea.java
on Alpine LinuxProgress
Issue
Contributors
<mbaesken@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26046/head:pull/26046
$ git checkout pull/26046
Update a local copy of the PR:
$ git checkout pull/26046
$ git pull https://git.openjdk.org/jdk.git pull/26046/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26046
View PR using the GUI difftool:
$ git pr show -t 26046
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26046.diff
Using Webrev
Link to Webrev Comment