Skip to content

8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block #26043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ravigupta30
Copy link
Contributor

@ravigupta30 ravigupta30 commented Jun 30, 2025

Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java left debris on system whenever fails its required frame.dispose() in finally block.

 finally {
            EventQueue.invokeAndWait(ExtraButtonDrag::disposeFrame);
        }
    public static void disposeFrame() {
        if (frame != null) {
            frame.dispose();
            frame = null;
        }
    }



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26043/head:pull/26043
$ git checkout pull/26043

Update a local copy of the PR:
$ git checkout pull/26043
$ git pull https://git.openjdk.org/jdk.git pull/26043/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26043

View PR using the GUI difftool:
$ git pr show -t 26043

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26043.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2025

👋 Welcome back rgupta! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 30, 2025
@openjdk
Copy link

openjdk bot commented Jun 30, 2025

@ravigupta30 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 30, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2025

Webrevs

@ravigupta30
Copy link
Contributor Author

any volunteer for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant