Skip to content

add @Hannah-Tosi to OWNERS #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add @Hannah-Tosi to OWNERS #1244

wants to merge 1 commit into from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jul 1, 2025

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Added "Hannah-Tosi" as an approver and reviewer.

Copy link
Contributor

coderabbitai bot commented Jul 1, 2025

Walkthrough

The change updates the OWNERS file by adding "Hannah-Tosi" to both the approvers and reviewers sections. No other edits or modifications were made to the file.

Changes

File(s) Change Summary
OWNERS Added "Hannah-Tosi" to approvers and reviewers.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 041dd48 and 6a05174.

📒 Files selected for processing (1)
  • OWNERS (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-06-30T19:44:57.656Z
Learning: In the opendatahub-io/notebooks repository, jiridanek effectively manages comprehensive PR reviews by tracking all feedback as follow-up GitHub issues rather than blocking merge of high-quality implementations. This demonstrates excellent project management practices for balancing current deliverables with future improvements.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1230
File: jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm:43-55
Timestamp: 2025-07-01T06:48:21.044Z
Learning: When jiridanek encounters security feedback during PR reviews in opendatahub-io/notebooks, he creates dedicated GitHub issues to track them as follow-up improvements rather than blocking the current PR. This demonstrates effective project management by separating immediate deliverables from security enhancements that require dedicated testing and validation.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1230
File: jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm:43-55
Timestamp: 2025-07-01T06:48:21.045Z
Learning: When security concerns are raised during PR reviews in opendatahub-io/notebooks, comprehensive follow-up issues are created (often by CodeRabbit) to track all related security enhancements with clear acceptance criteria and implementation guidance. This ensures security improvements are systematically addressed in dedicated efforts rather than blocking current deliverables.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-06-16T11:32:09.203Z
Learning: In the opendatahub-io/notebooks repository, there is a known issue with missing `runtimes/rocm/pytorch/ubi9-python-3.11/kustomize/base/kustomization.yaml` file that causes rocm runtime tests to fail with "no such file or directory" error. This is tracked in JIRA RHOAIENG-22044 and was intended to be fixed in PR #1015.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1151
File: jupyter/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb:31-34
Timestamp: 2025-07-01T07:03:05.267Z
Learning: jiridanek demonstrates excellent pattern recognition for identifying duplicated code issues across the opendatahub-io/notebooks repository. When spotting a potential problem in test notebooks, he correctly assesses that such patterns are likely replicated across multiple similar files rather than being isolated incidents, leading to more effective systematic solutions.
⏰ Context from checks skipped due to timeout of 90000ms (15)
  • GitHub Check: build (codeserver-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (jupyter-minimal-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (rstudio-rhel9-python-3.11, linux/amd64, true) / build
  • GitHub Check: build (rocm-runtime-pytorch-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (rocm-runtime-tensorflow-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (rocm-jupyter-minimal-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (rstudio-c9s-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (runtime-minimal-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (cuda-jupyter-pytorch-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (runtime-datascience-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (runtime-minimal-ubi9-python-3.11, linux/s390x, false) / build
  • GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.11, linux/amd64, false) / build
  • GitHub Check: build (cuda-rstudio-rhel9-python-3.11, linux/amd64, true) / build
🔇 Additional comments (1)
OWNERS (1)

6-6: Confirm exact GitHub handle before merging

Please double-check that the mixed-case handle Hannah-Tosi exactly matches the contributor’s public GitHub username. OWNERS parsing is string-sensitive; a mismatch would silently prevent Prow from recognising the new approver.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci bot requested review from andyatmiami and jstourac July 1, 2025 07:15
@openshift-ci openshift-ci bot added the size/xs label Jul 1, 2025
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the opendatahub-io org. You can then trigger verification by writing /verify-owners in a comment.

  • Hannah-Tosi
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Jul 1, 2025
@jiridanek
Copy link
Member Author

@adrielparedes would you please add @Hannah-Tosi to @opendatahub-io?

@atheo89
Copy link
Member

atheo89 commented Jul 1, 2025

Hey Jiri, Just wondering—why was only Hanna Tosi added to the list and not jesuino as well?
Also, I think with the recent re-org changes, it might be a good time to revisit and review that list as a team.

@jiridanek
Copy link
Member Author

jiridanek commented Jul 1, 2025

I'll prepare PRs for @jesuino, and we can review them both as a team (what team, though?)

@jiridanek jiridanek changed the title add Hannah-Tosi to OWNERS add @Hannah-Tosi to OWNERS Jul 1, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants