RHOAIENG-9499: docs(examples): begin drafting the Dockerfile and suitable README.md #1152
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jiridanek
changed the title
| jupyter-bokeh~=4.0.5 | ||
| jupyter-server~=2.15.0 | ||
| jupyter-server-proxy~=4.4.0 | ||
| jupyter-server-terminals~=0.5.3 | ||
| jupyterlab-git~=0.50.1 | ||
| jupyterlab-lsp~=5.1.0 | ||
| jupyterlab-widgets~=3.0.13 | ||
| jupyter-resource-usage~=1.1.1 | ||
| nbdime~=4.0.2 | ||
| nbgitpuller~=1.2.2 |
There was a problem hiding this comment.
this is a lot of packages, some can be removed to make the important ones stand out better
| odh-elyra==4.2.1 | ||
| kfp~=2.12.1 |
| matplotlib~=3.10.1 | ||
| numpy~=2.2.3 | ||
| # ... |
There was a problem hiding this comment.
this is to show that customers are free to add whatever additional python packages they want to use in their workbench
| ARG JUPYTER_REUSABLE_UTILS=jupyter/utils | ||
| ARG MINIMAL_SOURCE_CODE=jupyter/minimal/ubi9-python-3.11 | ||
| ARG DATASCIENCE_SOURCE_CODE=jupyter/datascience/ubi9-python-3.11 | ||
|
|
||
| # Emplace and activate our entrypoint script | ||
| COPY ${MINIMAL_SOURCE_CODE}/start-notebook.sh /opt/app-root/bin/ | ||
| ENTRYPOINT ["/opt/app-root/bin/start-notebook.sh"] | ||
| # Copy JupyterLab config from utils directory | ||
| COPY ${JUPYTER_REUSABLE_UTILS} /opt/app-root/bin/utils/ | ||
| # Copy Elyra setup script and various utils where start-notebook.sh expects it | ||
| COPY ${DATASCIENCE_SOURCE_CODE}/setup-elyra.sh ${DATASCIENCE_SOURCE_CODE}/utils /opt/app-root/bin/utils/ |
There was a problem hiding this comment.
the build relies heavily on the scripts start-notebook.sh and setup-elyra.sh elsewhere in this repository; I don't want to make a copy; customers probably should just make a copy
examples/README.md
Outdated
There was a problem hiding this comment.
there may be additional section about how to actually use this info
there are two options, either copy this example and make it your own, or build their own elyra-containing image by doing
FROM quay.io/modh/our-datascience-image:someversion
and then installing additional things
and being sure to end the dockerfile with
USER 1001:0
WORKDIR /opt/app-root/src
|
|
||
| Reference: https://github.com/opendatahub-io/odh-dashboard/blob/2ced77737a1b1fc24b94acac41245da8b29468a4/frontend/src/concepts/pipelines/elyra/utils.ts#L152-L162 | ||
|
|
||
| ## Image Streams |
There was a problem hiding this comment.
remove this, already covered in https://github.com/opendatahub-io/notebooks/blob/main/docs/workbench-imagestreams.md
https://issues.redhat.com/browse/RHOAIENG-9499
Description
How Has This Been Tested?
Merge criteria: