Update Tekton files to version v2.x.1 #1146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![odh-devops-app[bot]](https://avatars.githubusercontent.com/in/364424?s=60&v=4){kind=small}
RHOAIENG-24411: Create Juptyer Minimum Python 3.12 image
RHOAIENG-24438: Create Jupyter Data Science Python 3.12 Image
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @odh-devops-app[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…erLab Workbenches (#1030) * RHOAIENG-16568: [Bug] Unable to download notebook as a PDF from JupyterLab Workbenches * Running installation from a script * Adding test and fixing path * Fixing Script file name * Using minimal tmp file instead a fixed file * Removing and ignoring logs * Adding tex live to missing Dockerfiles * Formatting * Review changes * Removing unwanted line * Fixing type * Copying configuration in all images * Removing year from the TeXLive installation * Adding pandoc for a complete PDF export support * Updating comment about TeX live installation * Improving PDF export test * pandoc latest version and ignoring message * formatting fix * add "/usr/local/pandoc/bin/pandoc" to config.toml --------- Co-authored-by: Jiri Daněk <jdanek@redhat.com>
RHOAIENG-24471: Create Jupyter Pytorch Python 3.12 Image
…kbench-imagestreams.md` (#1155)
…ld-notebooks-pr-rhel.yaml`
* Exiting PDF install script with error code if commands fail * Changing to euxo, which gives better log output
…1154) * RHOAIENG-26702: Update codeflare-sdk versions and shas for v0.29.0 * Update Pipfile.lock files by piplock-renewal.yaml action --------- Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
….cpu for s390x (#1132) Signed-off-by: Nishan Acharya <Nishan.Acharya@ibm.com>
…concurrent skopeo instances running (#1165) * RHOAIENG-26264: throttle concurrent skopeo invocations Implements throttling for concurrent skopeo invocations in the `scripts/update-commit-latest-env.py` script by using an asyncio.Semaphore. This change addresses issue #1158. The script now uses a semaphore to limit the number of concurrent `skopeo inspect` operations to 22. This helps to: - Avoid overwhelming container registries with too many requests. - Prevent potential rate limiting issues. - Provide more stable execution under different network conditions. The `get_image_vcs_ref` function was updated to accept a semaphore, and the `inspect` function was updated to create and manage the semaphore, passing it to the image inspection tasks. * Revert: Revert accidental commit of test file This commit reverts the changes made to `manifests/base/params-latest.env` which was accidentally included in the previous commit (feat: Throttle concurrent skopeo invocations). The `params-latest.env` file in that location was created for testing purposes during development and should not be part of the final changeset. This commit restores it to its state prior to that accidental modification. * Refactor: Reduce semaphore scope in get_image_vcs_ref This commit refactors the get_image_vcs_ref function in `scripts/update-commit-latest-env.py`. The scope of the asyncio.Semaphore is now reduced to cover only the `asyncio.create_subprocess_exec` call for `skopeo` and the subsequent `process.communicate()` call. Processing of the skopeo output (JSON parsing, label extraction, and associated logging) has been moved outside of the semaphore block. This change is made to improve code clarity and provide a smaller diff for review, as per your feedback. The performance impact is expected to be negligible for this specific script, but the change aligns with best practices for minimizing resource holding time. * Revert: Correct state of manifests/base/params-latest.env This commit ensures that `manifests/base/params-latest.env` is restored to its state prior to the recent refactoring commit ("Refactor: Reduce semaphore scope in get_image_vcs_ref"). The file `manifests/base/params-latest.env` was unintentionally included in that refactoring commit. This commit reverts that specific file to the version present in the preceding commit ("Revert: Revert accidental commit of test file"), which should represent its correct state before the recent series of changes related to skopeo throttling. * Revert: Ensure correct state of manifests/base/params-latest.env This commit reverts the accidental inclusion of a test version of `manifests/base/params-latest.env` that occurred during the commit for a PEP 8 indentation fix ("Fix: Correct PEP 8 indentation in JSONDecodeError logging"). The file `manifests/base/params-latest.env` has been restored to its state from the commit prior to that indentation fix, which should be its correct, intended version. --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…notebooks-pr-rhel.yaml`
…notebooks-pr-rhel.yaml
…1166) This commit refactors the conditional package installation logic in runtimes/minimal/ubi9-python-3.11/Dockerfile.cpu to reduce duplication. Common packages (mesa-libGL and skopeo) are now defined in a variable, and architecture-specific packages for s390x are conditionally added to this variable. This improves maintainability and readability of the Dockerfile. This addresses issue #1161. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…--platform` (#1167) * Add s390x testing to CI using QEMU and --platform This commit introduces CI testing for the s390x architecture by leveraging QEMU user-mode emulation and Podman's --platform flag. This revised approach avoids running Podman-in-Docker. Key changes: - Added `docker/setup-qemu-action` to the main build job in `.github/workflows/build-notebooks-TEMPLATE.yaml` to enable the runner to execute s390x binaries. - Modified `ci/cached-builds/gen_gha_matrix_jobs.py` to generate a matrix including an `s390x` boolean flag. - Updated the `build` job in `.github/workflows/build-notebooks-TEMPLATE.yaml`: - It now conditionally sets `--platform=linux/s390x` for `podman build` commands via `CONTAINER_BUILD_CACHE_ARGS` when `matrix.s390x` is true. - PyTest execution is conditional: - Runs tests marked `s390x` for s390x builds. - Runs tests marked `not s390x` for amd64 builds. - OpenShift and Playwright tests are skipped for s390x builds. - The main workflow files (`build-notebooks-pr.yaml` and `build-notebooks-push.yaml`) pass the `--s390x-images` argument to the matrix generation script to control s390x builds (excluded for PRs, included for pushes). - s390x-specific tests for `pyzmq` and `mongocli` are included and marked with `@pytest.mark.s390x`. This approach provides a cleaner way to build and test for s390x by directly using Podman's multi-architecture capabilities, facilitated by QEMU on the runner. * RHOAIENG-26279: include s390x platform in build workflows and update matrix configuration * RHOAIENG-26279: streamline s390x platform configuration in build workflows * RHOAIENG-26279: remove s390x-specific conditions from workflows and streamline testing logic * RHOAIENG-26279: refine container build cache arguments to explicitly pass platform configuration * RHOAIENG-24348: remove s390x marker from mongocli binary test in JupyterLab * RHOAIENG-26279: update s390x platform conditions in matrix generation and fix JupyterLab test assertion formatting * RHOAIENG-26279: fix matrix generation by updating key from `targets` to `targets_with_platform` in `has_jobs` calculation * RHOAIENG-26279: fix matrix generation by updating key from `targets` to `targets_with_platform` in `has_jobs` calculation * RHOAIENG-26279: add explicit `choices` constraints for `--rhel-images` and `--s390x-images` arguments in matrix generation script * RHOAIENG-26279: remove unused `--s390x-images` validation in matrix generation script * RHOAIENG-26279: centralize s390x-compatible target list into `S390X_COMPATIBLE` set in matrix generation script * RHOAIENG-26279: rename JupyterLab test method for pyzmq to improve clarity * RHOAIENG-26279: refactor JupyterLab pyzmq test to use encoded function execution logic for cleaner implementation * RHOAIENG-26279: update JupyterLab pyzmq test to reorder imports and add comments for ruff and pyright noqa annotations * RHOAIENG-26279: add runtime image fixture and move pyzmq test to runtime-specific test module * RHOAIENG-26279: simplify runtime image validation logic, reorder imports, and improve socket variable naming * Update tests/containers/runtimes/runtime_test.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * RHOAIENG-26279: add workaround for s390x podman build issue by passing extra build args * RHOAIENG-26279: update runtime image fixture to use yield instead of return * RHOAIENG-26279: update runtime_image fixture scope from session to function * RHOAIENG-26279: update platform check from architecture to platform for s390x podman build workaround * RHOAIENG-26279: refactor runtime test to use context manager for container lifecycle management * RHOAIENG-26279: refactor runtime test to use context manager for container lifecycle management # Conflicts: # tests/containers/runtimes/runtime_test.py * RHOAIENG-26279: update s390x podman build workaround env variable to use undefined flag * RHOAIENG-26279: fix Python interpreter path in runtime test to use user venv * RHOAIENG-26279: remove unused WorkbenchContainer import and cleanup test logic * RHOAIENG-26279: update runtime test to handle exec output as bytes instead of string * RHOAIENG-26279: remove redundant failure case in runtime test cleanup logic * RHOAIENG-26279: skip image tests on s390x due to unresolvable dependency installation issue --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch-rocm-py311-ubi9-push.yaml` * #1371
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…on 3.12, Improved Naming) (#1359) * Added new set of imagestreams on the additional overlay with the 2025.2-beta version Update files add placeholders to all * Revert changes on the base runtime imagestreams * Add seperated pipeline runtimes imagestreams on the additional folder for the py312 * Rename the tag on ImageStreams to 2025.1
…stency in insta-merge workflow (#1374)
… name to avoid artifact upload failures due to artifact name clashes (#1375)
…py312 version (#1118) Co-authored-by: atheo89 <atheodorak@outlook.com>
odh-devops-app
bot
force-pushed
the
appstudio-notebooks-konflux-replicator
branch
from
e806eb5 to
dff5fe8
Compare
odh-devops-app
bot
force-pushed
the
appstudio-notebooks-konflux-replicator
branch
from
dff5fe8 to
a95541d
Compare
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* create new py312 tekton push pipelines
```
for file in odh-*-py311-*.yaml; do
cp "$file" "${file/py311/py312}"
done
```
* update content of new py312 files
…#1385) - Split `make refresh-pipfilelock-files` and branch push steps in piplock-renewal workflow for clarity. - Enhanced `pipenv lock` verbosity control in `Makefile`, added failure handling with detailed error logging.
It will just revert any fixes in there.
Add some missing images on the py312 all-images target
This is not everything needed to build all of the cuda images, but it's a necessary step, and the intention is for each achievable part to be easily reviewable. The pattern here is adapted from the NVidia Dockerfiles found at https://gitlab.com/nvidia/container-images/cuda/-/tree/master/dist/12.6.3/ubi9 - NVARCH is set to sbsa on arm64 - cuda-nvprof is only installed for amd64 (no build available for arm64 even) - Removed cuda/rhel9-python-3.11/ dir, since it appeared to just contain duplicate files from cuda/ * Rename mssql repo file * Don't hardcode amd64 in buildinputs tool
odh-devops-app
bot
force-pushed
the
appstudio-notebooks-konflux-replicator
branch
from
a95541d to
c43e156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
output-imagetags and CEL expressions in.tekton/to versionv2.x.1and branchtest-1.