Bug/mcp-error-handling #619
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `CreateStreamedResponse.php` - Added streaming support for code interpreter - `OutputCodeInterpreterToolCall.php` - New file for code interpreter output handling - `OutputMessageContentOutputTextAnnotationsContainerFile.php` - New file for container file annotations - `OutputMessageContentOutputText.php` - Updated to support container file annotations - `CodeInterpreterCall.php` - New streaming event handler - `OutputTextAnnotationAdded.php` - New streaming event for text annotations - `CodeInterpreterCodeDone.php` - New streaming event for code completion - `CodeInterpreterCodeDelta.php` - New streaming event for code deltas - `OutputItem.php` - Updated to handle code interpreter outputs - `CodeInterpreterTool.php` - New tool type definition
… code interpreter responses composer test now reports: • 896 PHPUnit tests PASS • Laravel Pint style PASS • php-stan level passes with zero errors.
test: enhance error handling tests for OutputMcpCall response
|
You might have to rebase your branch. I think you based it off your older branch, prior to the squash merge into main. |
|
Marking as draft in meantime. Conflicting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: enhance error handling tests for OutputMcpCall response
What:
Description:
Added support for handling various MCP call error formats in the OutputMcpCall class. The implementation now properly parses and normalizes error messages returned from OpenAI's MCP calls, regardless of the format they're presented in:
This ensures that users of the library can consistently access error messages from MCP calls without having to handle different response structures themselves.
Related:
N/A