Skip to content

Prevent SIP.js stack to crash app on re-register when there is already an outstanding REGISTER request #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent SIP.js stack to crash app on re-register when there is already an outstanding REGISTER request #1108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/api/registerer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,10 @@ export class Registerer {
// For that, calculate the delay as a percentage of the expiration time
this.registrationTimer = setTimeout(() => {
this.registrationTimer = undefined;
if (this.waiting) {
this.logger.warn("Outstanding REGISTER request already in progress, skipping re-registration");
return;
}
this.register();
}, (this.refreshFrequency / 100) * expires * 1000);

Expand Down