feat(Theme): new component #4387
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjamincanac Any thoughts on this? I'd love to finish out the rest of this MR, just wanted to get your initial thoughts. |
There was a problem hiding this comment.
Wouldn't it be easier to inject the provided ui prop inside the ui computed like we do for the app config? 🤔 https://github.com/nuxt/ui/blob/v3/src/runtime/components/Button.vue#L106
Also, I think it would be best to externalize the composable to be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #4250
❓ Type of change
📚 Description
Detailed in the issue: #4250
Needing Review
This MR is still in draft mode, but I have an initial POC made. I was hoping to get feedback on the approach and the changes before applying them to all components, and writing documentation.
📝 Checklist