[nrf fromlist] drivers: clock control: ironside dvfs hsfll #3006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends the clock control driver to support the new IronSide DVFS service in the local domain by introducing a new binding and driver specifically for Nordic nRF IronSide HSFLL. Key changes include:
- Adding the new DTS binding file for "nordic,nrf-iron-hsfll-local"
- Implementing the new clock control driver in clock_control_nrf_iron_hsfll_local.c to integrate the DVFS service
- Updating Kconfig, CMakeLists.txt, and board DTS files to enable and configure the new driver
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| dts/bindings/clock/nordic,nrf-iron-hsfll-local.yaml | New binding to describe the clock frequency and FICR properties |
| drivers/clock_control/clock_control_nrf_iron_hsfll_local.c | New driver implementing DVFS changes and clock configuration |
| drivers/clock_control/Kconfig.nrf | New Kconfig options to enable the local HSFLL driver and DVFS setup |
| drivers/clock_control/CMakeLists.txt | Updated build definitions to include the new driver |
| boards/nordic/nrf54h20dk/nrf54h20dk_nrf54h20_cpuapp_iron.dts | Updated board DTS to use the new "nordic,nrf-iron-hsfll-local" |
Comments suppressed due to low confidence (1)
drivers/clock_control/Kconfig.nrf:296
- [nitpick] Consider expanding the help text for CLOCK_CONTROL_NRF_IRON_HSFLL_LOCAL_REQ_LOW_FREQ to clarify its usage and the implications of scaling down to the lowest operating point after DVFS initialization.
help
| return i; | ||
| } | ||
|
|
||
| LOG_ERR("invalid frequency"); |
There was a problem hiding this comment.
Consider improving the error message in hsfll_resolve_spec_to_idx to indicate the acceptable frequency range or valid values, which may help integrators diagnose configuration issues.
Suggested change
| LOG_ERR("invalid frequency"); | |
| LOG_ERR("invalid frequency. Valid frequencies are: %u, %u, %u MHz", | |
| HSFLL_FREQ_LOW / MHZ(1), HSFLL_FREQ_MEDLOW / MHZ(1), HSFLL_FREQ_HIGH / MHZ(1)); |
Copilot uses AI. Check for mistakes.
lstnl
force-pushed
the
nrf-clock-ctrl-ironside-hsfll
branch
5 times, most recently
from
f27c3f3 to
c12816a
Compare
|
Extended clock control driver to support new DVFS service from IronSide secure domain. Added new compatible nrf-iron-hsfll-local which can be used to enable new DVFS service support in local domain. Upstream PR #: 92239 Signed-off-by: Łukasz Stępnicki <lukasz.stepnicki@nordicsemi.no>
lstnl
force-pushed
the
nrf-clock-ctrl-ironside-hsfll
branch
from
c12816a to
a2f3084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended clock control driver to support new DVFS service from IronSide secure domain. Added new compatible nrf-iron-hsfll-local which can be used to enable new DVFS service support in local domain.
Upstream PR #: 92239