[nrf fromlist] linker: Use zephyr,code-partition value #2979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce usage of values from devicetree if USE_DT_CODE_PARTITION Kconfig symbol is enabled. Currently even if this symbol is enabled, the FLASH_LOAD_OFFSET value is used in the linker script. The FLASH_LOAD_OFFSET symbol, even being promptless is such case, may be changed, leading to a very confusing situation, where devicetree values have no effect on the build. A good example of the build that wants to use exactly the same set of configs, but a different link address is the A/B update scheme (known ad Direct XIP in MCUboot), where the same application is linked to two different addresses. If the source of the address remains in the Kconifg, the current approach forces a usage of two different configurations. Upstream PR #: 91591 Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce usage of values from devicetree if USE_DT_CODE_PARTITION Kconfig symbol is enabled.
Currently even if this symbol is enabled, the FLASH_LOAD_OFFSET value is used in the linker script.
The FLASH_LOAD_OFFSET symbol, even being promptless is such case, may be changed, leading to a very confusing situation, where devicetree
values have no effect on the build.
A good example of the build that wants to use exactly the same set of
configs, but a different link address is the A/B update scheme
(known ad Direct XIP in MCUboot), where the same application is linked to two different addresses.
If the source of the address remains in the Kconifg, the current approach forces a usage of two different configurations.
Upstream PR #: 91591